Opened 5 months ago

Closed 5 months ago

#30878 closed enhancement (fixed)

some flake8 details in backend normaliz

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.3
Component: geometry Keywords:
Cc: jipilab, gh-LaisRast, gh-kliem, selia Merged in:
Authors: Frédéric Chapoton Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 310903a (Commits, GitHub, GitLab) Commit: 310903a5ef19d2b546f36b15cc53e17a2aa041b1
Dependencies: Stopgaps:

Status badges

Description

and also fix two lgtm warnings

nothing serious, mostly cosmetic changes

Change History (7)

comment:1 Changed 5 months ago by chapoton

  • Branch set to u/chapoton/30878
  • Status changed from new to needs_review

comment:2 Changed 5 months ago by git

  • Commit set to 310903a5ef19d2b546f36b15cc53e17a2aa041b1

Branch pushed to git repo; I updated commit sha1. New commits:

​310903asome details in backend pynormaliz

comment:3 Changed 5 months ago by chapoton

  • Summary changed from some flake8 details in backend pynormaliz to some flake8 details in backend normaliz

comment:4 Changed 5 months ago by gh-kliem

This seems inconsistent to me: 

-            h_vertices = [ list(v) + [1] for v in vertices ]
+            h_vertices = [list(v) + [1] for v in vertices]

-                dieq = [ ZZ(d*ieq_i) for ieq_i in ieq ]
+                dieq = [ ZZ(d * ieq_i) for ieq_i in ieq ]

comment:5 Changed 5 months ago by chapoton

well, I was tempted to remove (as suggested by flake8) all superfluous whitespace before or after brackets. But then I decide to try to keep the diff small, so I did that only once.

comment:6 Changed 5 months ago by gh-kliem

  • Reviewers set to Jonathan Kliem
  • Status changed from needs_review to positive_review

I think for i,j in enumerate... is better to read than for i, j in enumerate, but this might also be because I'm used to it and it seems to be against pep8.

comment:7 Changed 5 months ago by vbraun

  • Branch changed from u/chapoton/30878 to 310903a5ef19d2b546f36b15cc53e17a2aa041b1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.