Opened 2 years ago

Closed 22 months ago

#30842 closed enhancement (fixed)

Genus representatives

Reported by: Simon Brandhorst Owned by:
Priority: major Milestone: sage-9.3
Component: quadratic forms Keywords:
Cc: Merged in:
Authors: Simon Brandhorst Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f6d82ea (Commits, GitHub, GitLab) Commit: f6d82eac14ee5bf45a0d1980d1e948bd1b3ff31c
Dependencies: #30843 Stopgaps:

Status badges

Description

Implements a function which returns representatives for a genus of quadratic forms. Optional sage and Magma backend.

sage: IntegralLattice(9).genus().representatives()                           
(
[1 0 0 0 0 0 0 0 0]  [1 0 0 0 0 0 0 0 0]
[0 1 0 0 0 0 0 0 0]  [0 2 1 1 1 1 1 1 1]
[0 0 1 0 0 0 0 0 0]  [0 1 2 1 1 0 0 0 0]
[0 0 0 1 0 0 0 0 0]  [0 1 1 2 1 1 1 1 1]
[0 0 0 0 1 0 0 0 0]  [0 1 1 1 2 1 1 0 0]
[0 0 0 0 0 1 0 0 0]  [0 1 0 1 1 2 1 1 1]
[0 0 0 0 0 0 1 0 0]  [0 1 0 1 1 1 2 1 1]
[0 0 0 0 0 0 0 1 0]  [0 1 0 1 0 1 1 2 1]
[0 0 0 0 0 0 0 0 1], [0 1 0 1 0 1 1 1 2]
)

Change History (18)

comment:1 Changed 2 years ago by Simon Brandhorst

Dependencies: #30843

comment:2 Changed 2 years ago by Simon Brandhorst

Branch: u/sbrandhorst/genus_representatives

comment:3 Changed 23 months ago by git

Commit: 4e786f2ec45139e46a34f7c94bbdc69f8677d639

Branch pushed to git repo; I updated commit sha1. New commits:

b15922dAdded a Note block.
b6657afformatting
3bfdccfMerge branch 't/30843/abeliangroup_gap_quotient_group' into t/30842/genus_representatives
4e786f2docs

comment:4 Changed 23 months ago by Simon Brandhorst

Status: newneeds_review

comment:5 Changed 23 months ago by Travis Scrimshaw

Some quick comments (I haven't had time to fully read through it): You need to change MATH:: -> .. MATH::. Also, there are some PEP8 spacing that would be good to implement; mainly the ==0 -> == 0 and similar.

comment:6 Changed 23 months ago by Simon Brandhorst

Which one is better?
1)a==b and c==d
2)a == b and c == d I tend to 1) since it is the analogue of a*b + c*d vs a * b + c * d

comment:7 Changed 23 months ago by git

Commit: 4e786f2ec45139e46a34f7c94bbdc69f8677d639ab9361f676282014ff70e028fec5e22420df9a67

Branch pushed to git repo; I updated commit sha1. New commits:

ab9361fpep

comment:8 Changed 23 months ago by Travis Scrimshaw

That is an interesting point with and being another operator. However, I would still say 1 because it seems to be what is most widely used (and I am so used to seeing it that way, but that is my personal bias).

comment:9 Changed 23 months ago by git

Commit: ab9361f676282014ff70e028fec5e22420df9a6763ce0a20e971223367141a02edbff62dea9b0067

Branch pushed to git repo; I updated commit sha1. New commits:

63ce0a2pep pep pep pep pep pep

comment:10 Changed 23 months ago by Simon Brandhorst

There you go. Pep'ed all the files touched.

comment:11 Changed 23 months ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw

Thank you. Just add your name to the authors and set a positive review.

comment:12 Changed 23 months ago by Simon Brandhorst

Authors: Simon Brandhorst
Status: needs_reviewpositive_review

comment:13 Changed 23 months ago by Frédéric Chapoton

come on guys, there are some OUTPUT:: lurking around ! Please look at the patchbot complaints.

comment:14 Changed 23 months ago by Simon Brandhorst

Hi you are right of course, I should have waited for a green bot. Let's do that.

comment:15 Changed 23 months ago by git

Commit: 63ce0a20e971223367141a02edbff62dea9b0067121eff22d4fb3c700bce92a3dcc3c914262a00dc
Status: positive_reviewneeds_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

3fccfb5take care of patchbot complaints
121eff2fix a failing doctest

comment:16 Changed 23 months ago by git

Commit: 121eff22d4fb3c700bce92a3dcc3c914262a00dcf6d82eac14ee5bf45a0d1980d1e948bd1b3ff31c

Branch pushed to git repo; I updated commit sha1. New commits:

f6d82ealazy import and pickling

comment:17 Changed 23 months ago by Travis Scrimshaw

Status: needs_reviewpositive_review

Now there is a morally green patchbot.

comment:18 Changed 22 months ago by Volker Braun

Branch: u/sbrandhorst/genus_representativesf6d82eac14ee5bf45a0d1980d1e948bd1b3ff31c
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.