Opened 22 months ago

Closed 22 months ago

#30841 closed defect (fixed)

bootstrap: Do not depend on sage-env, sage-env-config

Reported by: mkoeppe Owned by:
Priority: critical Milestone: sage-9.3
Component: build Keywords:
Cc: dimpase, mjo, vbraun Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: b217a01 (Commits, GitHub, GitLab) Commit: b217a01e7e7566ed7c3cb61cfaa8c90db7563c32
Dependencies: Stopgaps:

Status badges

Description

Follow-up from #30795, #30128, #29174.

We make bootstrap independent of sage-env and sage-env-config. (This dependency was introduced in #21214 to get autotools from SAGE_LOCAL into PATH. This is no longer needed after the removal of the autotools spkg.)

Change History (9)

comment:1 Changed 22 months ago by mkoeppe

  • Branch set to u/mkoeppe/bootstrap__do_not_depend_on_sage_env__sage_env_config

comment:2 Changed 22 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to b217a01e7e7566ed7c3cb61cfaa8c90db7563c32
  • Dependencies #30795 deleted
  • Status changed from new to needs_review

New commits:

​b217a01bootstrap: Do not source src/bin/sage-env, sage-env-config

comment:3 Changed 22 months ago by dimpase

  • Reviewers set to Dima Pasechnik

well, this appears to cause a possible change in behavour, as sage-env-config etc potentially sets variables affecting ./configure, no?

comment:4 Changed 22 months ago by mkoeppe

bootstrap does not run configure

comment:5 Changed 22 months ago by dimpase

yes, but sourcing sage-env-config exports variables, and thus has effect on the environment, no?

comment:6 Changed 22 months ago by mkoeppe

Yes, eliminating these (unneeded) environment settings is the point of this ticket.

comment:7 Changed 22 months ago by dimpase

  • Status changed from needs_review to positive_review

ok.

comment:8 Changed 22 months ago by mkoeppe

Thanks!

comment:9 Changed 22 months ago by vbraun

  • Branch changed from u/mkoeppe/bootstrap__do_not_depend_on_sage_env__sage_env_config to b217a01e7e7566ed7c3cb61cfaa8c90db7563c32
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.