Opened 21 months ago
Closed 20 months ago
#30797 closed defect (fixed)
Bug in modular sqrt when extend is False and all is True
Reported by: | gh-jtnydv25 | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.3 |
Component: | number fields | Keywords: | bug |
Cc: | tscrim, vdelecroix | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 0815aa0 (Commits, GitHub, GitLab) | Commit: | 0815aa0728c9ba3bbd1fe188a9b04b525476d64b |
Dependencies: | Stopgaps: |
Description
sage: GF(103)(-1).sqrt(extend=False, all=True) ... ValueError: self must be a square
It should return [] instead.
Change History (4)
comment:1 Changed 21 months ago by
- Branch set to u/chapoton/30797
- Commit set to 0815aa0728c9ba3bbd1fe188a9b04b525476d64b
- Milestone changed from sage-9.2 to sage-9.3
- Status changed from new to needs_review
comment:3 Changed 21 months ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:4 Changed 20 months ago by
- Branch changed from u/chapoton/30797 to 0815aa0728c9ba3bbd1fe188a9b04b525476d64b
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
thx, here is a fix
New commits:
trac 30797 fix sqrt corner case for Zmod integers