Implementation of semistandard tableaux as pathtableaux

[Bruce]

This is an implementation of the abstract base class PathTableau?. This implementation is for semistandard tableaux, represented as a chain of partitions (essentially, the Gelfand-Tsetlin pattern). This generalises the jeu-de-taquin operations of rectification, promotion, evacuation from standard tableaux to semistandard tableaux. The local rule is the Bender-Knuth involution.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​af9ae79	Started testing
​b72c4fe	More testing
​d64fd5f	More testing
​400ce6d	More testing, TestSuite fails
​3cb61d4	Took out Partitions
​ed8d141	Passed unit tests
​eb2c9c9	All tests passed.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​a90f69e

Completed coverage

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​b83bd7d

Removed trailing white spaces

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​48fa41f

Merge branch 'develop' into semistandardpath

[chapoton]

First lines of docs should say "Convert", "Check", etc instead of "Converts", "Checks", etc

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​ab4cbd9	Rewroting local rule
​6578476	Now works with skew tableaux
​fc0b7db	More testing
​c85a4b3	Added testing for rectify
​89ba5ac	More testing

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​57cf0fb

Added verbose option

[Bruce]

Could someone please explain why this has failed testing?

Thanks

[chapoton]

Because the sage installation of the patchbot has a failing doctest. Nothing to do with your ticket. So far, nobody has taken up the task to fix this issue with pexpect and singular interface.

[chapoton]

missing a double colon here

+        TESTS:

The following should not be indented (never indent after a single colon)

+    INPUT:
+
+        * a sequence of partitions
+        * a sequence of lists/tuples
+        * a semistandard tableau
+        * a Gelfand-Tsetlin pattern

[chapoton]

This should take double backticks

+        Return `True` if `self` is skew.

Single backticks are for latex code (same as $)

[chapoton]

Missing a final dot here:

+        Rectify `self`

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​f72ef26

Fixed documentation

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​fc66fca

More corrections to doc strings

[chapoton]

Thanks. Now the syntax of

+    The :class:`SemistandardSkewTableau is not implemented.

is missing the backtick after SemistandardSkewTableau

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​4ca70e1

A correction

[tscrim]

A few minor comments:

I would rename SemistandardPath to be SemistandardPathTableau to make the name more explicit. Also SemistandardPaths is grammatically wrong as you want SemistandardPathTableaux.

You should add more explanation there for the INPUT:, mainly stating it "Can be one of the following:". There also needs to be at least one test for each of these input types. Can it also take a skew semistandard tableau? I think it should be able to. How about a skew partition then regular partitions? (This one, I would say it is fine the leave off and if someone does give this, I would be a bit surprised.)

For check, it would be good to have actual EXAMPLES::.

local_rule should have a 1-line description, then the rest of it should be separated in another paragraph with more details.

Error messages should start with lowercase letters (this is a Python convention we try to follow).

In rectify(), instead of using Partition(data), it would be faster to use _Partitions(data). Although it would be best to not actually construct partitions, but instead keep them as tuples. Similarly, instead of calling SemistandardPath, you can do P.element_class(P, data), where P = self.parent().

-if inner == None:
+if inner is None:

-return self[0] != ()
+return bool(self[0])

-        lt = list(self)
-        if lt[0] == ():
-            lt = lt[1:]
-        lt.reverse()
+        if not lt[-1]:
+            lt.pop()
         return GelfandTsetlinPattern([list(a) for a in lt])

In _test_jdt_promotion, could you make the try-except block more local to the line you expect to fail? It looks weird to have it around the actual test run.

General PEP8 stuff such as spaces

-def rectify(self,inner=None,verbose=False):
+def rectify(self, inner=None, verbose=False):

-        for i in range(1,len(self)-1):
-            if not all(r>=s for r,s in zip(self[i+1],self[i])):
+        for i in range(1, len(self)-1):
+            if not all(r >= s for r, s in zip(self[i+1], self[i])):

(but not necessarily limited to these).

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​8b4ff75	Corrections to documentation
​334d1a3	Changed name to SemistandardPathTableau(x)
​67334e7	Merge branch 'develop' into semistandardpath
​06c2bce	Changed names, removed Partition, edited documentation, ...
​82ce2e7	Minor edits

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​cf2be3b

Edited doctests

[tscrim]

Thank you. A few other little things I noticed on a second pass:

• You need to add the file to the big combinat module list for the documentation. (Actually, we forgot this for the frieze patterns. You can add it in here too if you want, but perhaps another ticket.)
• I think this is better formatting since it is code input:

  -This is implemented by toggling the entries of the `i`-th list.
  -The allowed range for `i` is 0 < `i` < len(self)-1 so any row except
  +This is implemented by toggling the entries of the ``i``-th list.
  +The allowed range for ``i`` is ``0 < i < len(self)-1`` so any row except
  

• if lt[-1] == (): -> if not lt[-1]:

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​aa7526f

Minor edits

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​6b69171

Added module to documentation

[tscrim]

The doctests in is_integral are not indented, which is causing the docbuild to fail.

[tscrim]

This will also likely conflict with #30870 and should have that as a dependency.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​414ea30

Indented Examples in is_integral

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​8c1dd5c	Added frieze module to documentation
​30d46dc	Merge branch 'friezedoc' into semistandardpath
​38604ea	Fixing docbuild for frieze patterns.
​4c3240e	Alphabetical order.
​13885d1	Merge branch 'friezedoc' into semistandardpath