Changes between Initial Version and Version 27 of Ticket #30748


Ignore:
Timestamp:
12/19/20 09:08:20 (10 months ago)
Author:
gh-tobiasdiez
Comment:

Ok, I've extracted it to #31080. But I would still ask you to also review this ticket, as otherwise I have to subtract it from some of my other tickets (which is not as easy as just pulling the new version of a branch).

Why don't you like the context manager? I think it's the right tool, as we are managing a local state.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30748

    • Property Status changed from new to needs_review
    • Property Cc chapoton tscrim added
    • Property Dependencies changed from to #31080
    • Property Milestone changed from sage-9.2 to sage-9.3
    • Property Keywords sd111 added
    • Property Commit changed from 99ae00c2ecb1ffcb8895697f34861f05dea840e6 to d4d94a8dec4d876517974bc94de3b83ede14061f
  • Ticket #30748 – Description

    initial v27  
    1 In #22752 it was introduced that when a lazy import is used during startup, then an RuntimeException is thrown. This leads to problems if you want to use code with lazy imports in a library mode (e.g. in standalone tests or python scripts). To support these use cases, I've degraded the exception to a print statement.
    2 
    3 Another possible solution would be to also introduce a `start_startup` method that is used at the very beginning of loading sage, and then only consider everything between `start_startup` and `finish_startup` as "startup".
     1Convert startup methods to context manager.