Opened 13 months ago

Closed 11 months ago

Last modified 10 months ago

#30747 closed enhancement (fixed)

Deprecate sage.misc.package functions standard_packages, optional_packages, experimental_packages

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-9.3
Component: refactoring Keywords:
Cc: arojas, jhpalmieri, fbissey, isuruf Merged in:
Authors: Matthias Koeppe Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 8ccc157 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

These functions are superseded by the more general function list_packages.

This is also a step toward deprecating all of sage.misc.package.

Change History (17)

comment:1 Changed 12 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:2 Changed 12 months ago by mkoeppe

  • Cc isuruf added
  • Description modified (diff)

comment:3 Changed 12 months ago by mkoeppe

  • Dependencies changed from #30746 to #30746, #30712

comment:4 Changed 12 months ago by mkoeppe

  • Dependencies changed from #30746, #30712 to #30746, #30712, #30748

comment:5 Changed 12 months ago by mkoeppe

  • Dependencies changed from #30746, #30712, #30748 to #30746, #30712, #30846

comment:6 Changed 12 months ago by mkoeppe

  • Description modified (diff)

comment:7 Changed 12 months ago by mkoeppe

  • Branch set to u/mkoeppe/deprecate_all_of_sage_misc_package_except_for_packagenotfounderror

comment:8 Changed 12 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to f2a4e39990eb93d5a8acca197fa400ecede40272
  • Dependencies changed from #30746, #30712, #30846 to #30712, #30846
  • Description modified (diff)
  • Priority changed from major to minor
  • Status changed from new to needs_review
  • Summary changed from Deprecate all of sage.misc.package except for PackageNotFoundError to Deprecate sage.misc.package functions standard_packages, optional_packages, experimental_packages

New commits:

8ab2285Gracefully fail if pip is not correctly installed
ec90687Merge branch 'public/build/hardenPip' of git://trac.sagemath.org/sage into t/30747/deprecate_all_of_sage_misc_package_except_for_packagenotfounderror
044fcc0Move sage-list-packages from src/bin (sagelib) to build/bin (sage_bootstrap)
0085fdeMerge branch 'u/mkoeppe/move__src_bin_sage_list_packages__to__build_bin_' of git://trac.sagemath.org/sage into t/30747/deprecate_all_of_sage_misc_package_except_for_packagenotfounderror
f2a4e39sage.misc.package: Deprecate standard_packages, optional_packages, experimental_packages

comment:9 Changed 11 months ago by mkoeppe

  • Dependencies #30712, #30846 deleted
  • Description modified (diff)

comment:10 Changed 11 months ago by git

  • Commit changed from f2a4e39990eb93d5a8acca197fa400ecede40272 to 8ccc15734fb09a3db16b11d960de9dfc3075fd3c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8ccc157sage.misc.package: Deprecate standard_packages, optional_packages, experimental_packages

comment:11 Changed 11 months ago by jhpalmieri

  • Reviewers set to John Palmieri

Looks okay to me.

comment:12 Changed 11 months ago by mkoeppe

positive review?

comment:13 Changed 11 months ago by jhpalmieri

  • Status changed from needs_review to positive_review

Yes, sorry.

comment:14 Changed 11 months ago by mkoeppe

Thanks!

comment:15 Changed 11 months ago by vbraun

  • Branch changed from u/mkoeppe/deprecate_all_of_sage_misc_package_except_for_packagenotfounderror to 8ccc15734fb09a3db16b11d960de9dfc3075fd3c
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:16 follow-up: Changed 10 months ago by chapoton

  • Commit 8ccc15734fb09a3db16b11d960de9dfc3075fd3c deleted

comment:17 in reply to: ↑ 16 Changed 10 months ago by mkoeppe

Replying to chapoton:

the doctests in misc/package are sometimes failing, see

https://patchbot.sagemath.org/log/31060/Linux/60-Ubuntu_SMP_Fri_Nov_6_10:37:59_UTC_2020/x86_64/5.4.0-54-generic/petitbonum/2020-12-16%2023:45:16?short

As part of #30940, some of these doctests are made less strict so that they work better in incremental builds that have some old packages still installed. - Needs review

Note: See TracTickets for help on using tickets.