Opened 10 months ago

Closed 8 months ago

#30724 closed enhancement (fixed)

src/bin/sage-env, src/bin/sage-env-config.in: Remove PYTHON_FOR_VENV

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.3
Component: build: configure Keywords:
Cc: jhpalmieri, dimpase, fbissey Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 4bfa0ea (Commits, GitHub, GitLab) Commit: 4bfa0ea5b2c803cc15e21a88f0f5e1c4eb77faaa
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

Instead, define it in build/make/Makefile.in.

With this ticket, the MACOSX_DEPLOYMENT_TARGET handling uses a new (unexported) configuration variable defined by sage-env-config; see also #30711.

This cleans up the sage runtime environment - one fewer environment variable.

It is also preparation for #29013.

Change History (7)

comment:1 Changed 10 months ago by mkoeppe

  • Branch set to u/mkoeppe/src_bin_sage_env__src_bin_sage_env_config_in__remove_python_for_venv

comment:2 Changed 10 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 4bfa0ea5b2c803cc15e21a88f0f5e1c4eb77faaa
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

91b4c0fbuild/make/Makefile.in: Set PYTHON_FOR_VENV here, do not rely on sage-env to set it
1955fadsrc/bin/sage-env: Set MACOSX_DEPLOYMENT_TARGET based on config variable SAGE_MACOSX_DEPLOYMENT_TARGET
4bfa0easrc/bin/sage-env-config.in: Do not set PYTHON_FOR_VENV

comment:3 Changed 9 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:4 Changed 9 months ago by mkoeppe

Needs review

comment:5 Changed 9 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

ok, this works

comment:6 Changed 9 months ago by mkoeppe

Thanks!

comment:7 Changed 8 months ago by vbraun

  • Branch changed from u/mkoeppe/src_bin_sage_env__src_bin_sage_env_config_in__remove_python_for_venv to 4bfa0ea5b2c803cc15e21a88f0f5e1c4eb77faaa
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.