Opened 20 months ago

Closed 19 months ago

#30720 closed defect (fixed)

Fix gap_packages for gcc 10

Reported by: mkoeppe Owned by:
Priority: critical Milestone: sage-9.3
Component: packages: optional Keywords:
Cc: dimpase, jhpalmieri, soehms, vbraun Merged in:
Authors: Dima Pasechnik, Matthias Koeppe Reviewers: Matthias Koeppe, Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: f89dc20 (Commits, GitHub, GitLab) Commit: f89dc20b41e57f49268edf6cccb0eed2cb2c081d
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

The optional package gap_packages fails to build on various platforms (​https://github.com/sagemath/sage/actions/runs/281307759): ubuntu-trusty, debian-bullseye, debian-sid, linuxmint-17.

We add patches extracted from the GAP/libsemigroup update ticket #29314 (which may not be ready for Sage 9.2)

Change History (20)

comment:1 Changed 20 months ago by mkoeppe

  • Branch set to u/mkoeppe/fix_gap_packages_for_gcc_10__xcode_12

comment:2 Changed 20 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to f89dc20b41e57f49268edf6cccb0eed2cb2c081d
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​c26eb00fix cohomolo pkg code to allow build with gcc10
​102946dbuild/pkgs/gap_packages/patches/cohomolo-gcc10.patch: Backport
​2c30b34clang 12 (macOS XCode 12) needs extra includes
​f89dc20build/pkgs/gap_packages/patches/guava_leon_includes.patch: Backport

comment:3 Changed 20 months ago by mkoeppe

  • Description modified (diff)
  • Summary changed from Fix gap packages for gcc 10, Xcode 12 to Fix gap_packages for gcc 10, Xcode 12

comment:4 Changed 20 months ago by git

  • Commit changed from f89dc20b41e57f49268edf6cccb0eed2cb2c081d to b834ae6cfc2a9b204f3fbd52cc9abab62e550e5b

Branch pushed to git repo; I updated commit sha1. New commits:

​b834ae6.github/workflows/tox-{optional,experimental}.yml: Test with Xcode 12 too

comment:5 Changed 20 months ago by mkoeppe

  • Reviewers set to https://github.com/mkoeppe/sage/actions/runs/288417931

comment:6 Changed 20 months ago by mkoeppe

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/288417931 to https://github.com/mkoeppe/sage/actions/runs/288422214

comment:7 Changed 20 months ago by jhpalmieri

Does this currently fail with Xcode 12? The summary mentions it but not the description.

comment:8 Changed 20 months ago by mkoeppe

It's what I have gathered from the tickets but I have not verified it myself. The GH Actions workflows prior to this ticket have only tested standard packages with Xcode 12, but not optional packages.

comment:9 Changed 20 months ago by dimpase

  • Authors changed from Matthias Koeppe to Matthias Koeppe, Dima Pasechnik

comment:10 Changed 20 months ago by mkoeppe

This seems to fix it for the gcc 10 platforms (for example debian-bullseye - ​https://github.com/mkoeppe/sage/runs/1206658827).

comment:11 Changed 20 months ago by mkoeppe

No results regarding Xcode 12 from GH Actions because the homebrew package installation fails and the build does not even start (​https://github.com/mkoeppe/sage/runs/1206657776)

This would benefit from local testing on macOS with Xcode 12...

comment:12 Changed 20 months ago by dimpase

I thusly approve the 1st four commits - I tested them.

I don't have a working install of XCode 12 now, as I updated by macOS to version 11, and the hell is breaking looser with each new beta there (I guess I can roll back to macOS 10.15...)

comment:13 Changed 20 months ago by git

  • Commit changed from b834ae6cfc2a9b204f3fbd52cc9abab62e550e5b to f89dc20b41e57f49268edf6cccb0eed2cb2c081d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:14 follow-up: Changed 20 months ago by mkoeppe

  • Authors changed from Matthias Koeppe, Dima Pasechnik to Dima Pasechnik, Matthias Koeppe
  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/288422214 to Matthias Koeppe, Dima Pasechnik
  • Status changed from needs_review to positive_review

OK, I have taken out the GH Actions fix, to be revisited on another ticket. Let's get this in.

comment:15 in reply to: ↑ 14 Changed 20 months ago by mkoeppe

Replying to mkoeppe:

OK, I have taken out the GH Actions fix, to be revisited on another ticket.

That's #30726

comment:16 Changed 20 months ago by jhpalmieri

For what it's worth, gap_packages fails for me with Xcode 12, with the usual sort of error: 

gcc -c -O -fno-builtin gpd.c 
gpd.c:37:7: error: implicit declaration of function 'gpprog' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  if (gpprog()== -1) exit(1);
      ^
1 error generated.

That happens with or without this branch.

comment:17 Changed 20 months ago by mkoeppe

  • Summary changed from Fix gap_packages for gcc 10, Xcode 12 to Fix gap_packages for gcc 10

Thanks for testing. Let's take care of Xcode 12 on a follow-up ticket then

comment:18 Changed 20 months ago by mkoeppe

That's #30729

comment:19 Changed 19 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:20 Changed 19 months ago by vbraun

  • Branch changed from u/mkoeppe/fix_gap_packages_for_gcc_10__xcode_12 to f89dc20b41e57f49268edf6cccb0eed2cb2c081d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.