Opened 16 months ago
Closed 14 months ago
#30709 closed enhancement (fixed)
Extract cython config to new module
Reported by:  ghtobiasdiez  Owned by:  

Priority:  major  Milestone:  sage9.3 
Component:  build  Keywords:  
Cc:  mkoeppe  Merged in:  
Authors:  Tobias Diez  Reviewers:  Matthias Koeppe 
Report Upstream:  N/A  Work issues:  
Branch:  cc96c6d (Commits, GitHub, GitLab)  Commit:  cc96c6dbae448cd361e798a1f29ec5bf10b0c57b 
Dependencies:  Stopgaps: 
Description
As suggested in #30371, the cython config is extracted to a new module to make it easier to reuse it in the editable install.
Change History (15)
comment:1 Changed 16 months ago by
 Status changed from new to needs_review
comment:2 Changed 16 months ago by
comment:3 Changed 16 months ago by
 Reviewers set to Matthias Koeppe
 Status changed from needs_review to positive_review
comment:4 Changed 16 months ago by
comment:5 Changed 15 months ago by
 Milestone changed from sage9.2 to sage9.3
comment:6 Changed 15 months ago by
 Status changed from positive_review to needs_work
See patchbot:
[dochtml] [arithgrou] The inventory files are in local/share/doc/sage/inventory/en/reference/arithgroup. [dochtml] Build finished. The built documents can be found in /home/sagemath/sage9.1/local/share/doc/sage/inventory/en/reference/arithgroup [dochtml] [graphs ] building [inventory]: targets for 73 source files that are out of date [dochtml] [graphs ] updating environment: [new config] 73 added, 0 changed, 0 removed [dochtml] [combinat ] /home/sagemath/sage9.1/local/lib/python3.7/sitepackages/sage/combinat/crystals/mv_polytopes.py:docstring of sage.combinat.crystals.mv_polytopes.MVPolytope.plot:22: WARNING: Exception occurred in plotting mv_polytopes1 [dochtml] [combinat ] from /home/sagemath/sage9.1/src/doc/en/reference/combinat/sage/combinat/crystals/mv_polytopes.rst: [dochtml] [combinat ] Traceback (most recent call last): [dochtml] [combinat ] File "/home/sagemath/sage9.1/local/lib/python3.7/sitepackages/matplotlib/sphinxext/plot_directive.py", line 472, in run_code [dochtml] [combinat ] exec(code, ns) [dochtml] [combinat ] File "<string>", line 4, in <module> [dochtml] [combinat ] File "/home/sagemath/sage9.1/local/lib/python3.7/sitepackages/sage/combinat/root_system/root_lattice_realizations.py", line 2053, in plot [dochtml] [combinat ] G += self.plot_roots(roots, plot_options=plot_options) [dochtml] [combinat ] File "/home/sagemath/sage9.1/local/lib/python3.7/sitepackages/sage/combinat/root_system/root_lattice_realizations.py", line 2299, in plot_roots [dochtml] [combinat ] roots = Family(roots, self) [dochtml] [combinat ] File "/home/sagemath/sage9.1/local/lib/python3.7/sitepackages/sage/sets/family.py", line 406, in Family [dochtml] [combinat ] return LazyFamily(indices, function, name) [dochtml] [combinat ] File "/home/sagemath/sage9.1/local/lib/python3.7/sitepackages/sage/sets/family.py", line 908, in __init__ [dochtml] [combinat ] self.set = copy(set) [dochtml] [combinat ] File "/usr/lib/python3.7/copy.py", line 106, in copy [dochtml] [combinat ] return _reconstruct(x, None, *rv) [dochtml] [combinat ] File "/usr/lib/python3.7/copy.py", line 274, in _reconstruct [dochtml] [combinat ] y = func(*args) [dochtml] [combinat ] File "stringsource", line 7, in sage.structure.sage_object.__pyx_unpickle_SageObject (build/cythonized/sage/structure/sage_object.c:11738) [dochtml] [combinat ] TypeError: sage.structure.sage_object.SageObject.__new__(FiniteFamily_with_category) is not safe, use FiniteFamily_with_category.__new__() [dochtml] [combinat ] /home/sagemath/sage9.1/local/lib/python3.7/sitepackages/sage/combinat/crystals/mv_polytopes.py:docstring of sage.combinat.crystals.mv_polytopes.MVPolytopes:101: WARNING: Exception occurred in plotting mv_polytopes2 [dochtml] [combinat ] from /home/sagemath/sage9.1/src/doc/en/reference/combinat/sage/combinat/crystals/mv_polytopes.rst:
comment:7 Changed 15 months ago by
Looks like auto_pickle=False,
was lost
comment:8 Changed 15 months ago by
 Commit changed from 1aef37625ee4af3da61b6f7493a3ac14a0b17fde to a646a24fde493cc942671e166314628827a0d9ac
comment:9 Changed 15 months ago by
 Status changed from needs_work to needs_review
comment:10 followup: ↓ 11 Changed 15 months ago by
Oh, that was indeed an overlook on my side. Thanks for fixing it. The patchbot complains about malformed blocks, which I don't really understand.
comment:11 in reply to: ↑ 10 Changed 15 months ago by
Replying to ghtobiasdiez:
The patchbot complains about malformed blocks, which I don't really understand.
"Returns" should be "Return" according to style guide.
comment:12 Changed 15 months ago by
 Commit changed from a646a24fde493cc942671e166314628827a0d9ac to cc96c6dbae448cd361e798a1f29ec5bf10b0c57b
Branch pushed to git repo; I updated commit sha1. New commits:
cc96c6d  Returns > Return

comment:13 Changed 15 months ago by
 Status changed from needs_review to positive_review
comment:14 Changed 15 months ago by
Thanks!
comment:15 Changed 14 months ago by
 Branch changed from public/build/cythonConfig to cc96c6dbae448cd361e798a1f29ec5bf10b0c57b
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Thanks!