Opened 2 years ago

Closed 2 years ago

#30709 closed enhancement (fixed)

Extract cython config to new module

Reported by: Tobias Diez Owned by:
Priority: major Milestone: sage-9.3
Component: build Keywords:
Cc: Matthias Köppe Merged in:
Authors: Tobias Diez Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: cc96c6d (Commits, GitHub, GitLab) Commit: cc96c6dbae448cd361e798a1f29ec5bf10b0c57b
Dependencies: Stopgaps:

Status badges

Description

As suggested in #30371, the cython config is extracted to a new module to make it easier to reuse it in the editable install.

Change History (15)

comment:1 Changed 2 years ago by Tobias Diez

Status: newneeds_review

comment:2 Changed 2 years ago by Matthias Köppe

Authors: Tobias Diez

comment:3 Changed 2 years ago by Matthias Köppe

Reviewers: Matthias Koeppe
Status: needs_reviewpositive_review

comment:4 Changed 2 years ago by Tobias Diez

Thanks!

comment:5 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.2sage-9.3

comment:6 Changed 2 years ago by Volker Braun

Status: positive_reviewneeds_work

See patchbot:

[dochtml] [arithgrou] The inventory files are in local/share/doc/sage/inventory/en/reference/arithgroup.
[dochtml] Build finished. The built documents can be found in /home/sagemath/sage-9.1/local/share/doc/sage/inventory/en/reference/arithgroup
[dochtml] [graphs   ] building [inventory]: targets for 73 source files that are out of date
[dochtml] [graphs   ] updating environment: [new config] 73 added, 0 changed, 0 removed
[dochtml] [combinat ] /home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/combinat/crystals/mv_polytopes.py:docstring of sage.combinat.crystals.mv_polytopes.MVPolytope.plot:22: WARNING: Exception occurred in plotting mv_polytopes-1
[dochtml] [combinat ]  from /home/sagemath/sage-9.1/src/doc/en/reference/combinat/sage/combinat/crystals/mv_polytopes.rst:
[dochtml] [combinat ] Traceback (most recent call last):
[dochtml] [combinat ]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/matplotlib/sphinxext/plot_directive.py", line 472, in run_code
[dochtml] [combinat ]     exec(code, ns)
[dochtml] [combinat ]   File "<string>", line 4, in <module>
[dochtml] [combinat ]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/combinat/root_system/root_lattice_realizations.py", line 2053, in plot
[dochtml] [combinat ]     G += self.plot_roots(roots, plot_options=plot_options)
[dochtml] [combinat ]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/combinat/root_system/root_lattice_realizations.py", line 2299, in plot_roots
[dochtml] [combinat ]     roots = Family(roots, self)
[dochtml] [combinat ]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/sets/family.py", line 406, in Family
[dochtml] [combinat ]     return LazyFamily(indices, function, name)
[dochtml] [combinat ]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/sets/family.py", line 908, in __init__
[dochtml] [combinat ]     self.set = copy(set)
[dochtml] [combinat ]   File "/usr/lib/python3.7/copy.py", line 106, in copy
[dochtml] [combinat ]     return _reconstruct(x, None, *rv)
[dochtml] [combinat ]   File "/usr/lib/python3.7/copy.py", line 274, in _reconstruct
[dochtml] [combinat ]     y = func(*args)
[dochtml] [combinat ]   File "stringsource", line 7, in sage.structure.sage_object.__pyx_unpickle_SageObject (build/cythonized/sage/structure/sage_object.c:11738)
[dochtml] [combinat ] TypeError: sage.structure.sage_object.SageObject.__new__(FiniteFamily_with_category) is not safe, use FiniteFamily_with_category.__new__()
[dochtml] [combinat ] /home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/combinat/crystals/mv_polytopes.py:docstring of sage.combinat.crystals.mv_polytopes.MVPolytopes:101: WARNING: Exception occurred in plotting mv_polytopes-2
[dochtml] [combinat ]  from /home/sagemath/sage-9.1/src/doc/en/reference/combinat/sage/combinat/crystals/mv_polytopes.rst:

comment:7 Changed 2 years ago by Matthias Köppe

Looks like auto_pickle=False, was lost

comment:8 Changed 2 years ago by git

Commit: 1aef37625ee4af3da61b6f7493a3ac14a0b17fdea646a24fde493cc942671e166314628827a0d9ac

Branch pushed to git repo; I updated commit sha1. New commits:

3fcd71fMerge tag '9.3.beta0' into t/30709/public/build/cythonConfig
a646a24src/sage_setup/cython_options.py: Restore auto_pickle=False

comment:9 Changed 2 years ago by Matthias Köppe

Status: needs_workneeds_review

comment:10 Changed 2 years ago by Tobias Diez

Oh, that was indeed an overlook on my side. Thanks for fixing it. The patchbot complains about malformed blocks, which I don't really understand.

comment:11 in reply to:  10 Changed 2 years ago by Matthias Köppe

Replying to gh-tobiasdiez:

The patchbot complains about malformed blocks, which I don't really understand.

"Returns" should be "Return" according to style guide.

comment:12 Changed 2 years ago by git

Commit: a646a24fde493cc942671e166314628827a0d9accc96c6dbae448cd361e798a1f29ec5bf10b0c57b

Branch pushed to git repo; I updated commit sha1. New commits:

cc96c6dReturns -> Return

comment:13 Changed 2 years ago by Matthias Köppe

Status: needs_reviewpositive_review

comment:14 Changed 2 years ago by Tobias Diez

Thanks!

comment:15 Changed 2 years ago by Volker Braun

Branch: public/build/cythonConfigcc96c6dbae448cd361e798a1f29ec5bf10b0c57b
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.