Opened 13 years ago
Closed 13 years ago
#3070 closed defect (fixed)
[with patch, positive review] bug in SymmetricGroup(1).cayley_graph()
Reported by: | mabshoff | Owned by: | boothby |
---|---|---|---|
Priority: | major | Milestone: | sage-3.0.1 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
In https://groups.google.com/group/sage-support/browse_thread/thread/443ce49730b43396 M. Fix reported:
Hello- I input the following: sage: s1 = SymmetricGroup(1) sage: s = s1.cayley_graph() sage: s.vertices() [] Shouldn't the set of vertices have one element in it for the identity? s1 reports this element, but as shown the graph does not. I suppose this is trivial, but it seems like it should be fixed at some point. I am, however, still fairly new to SAGE, and could easily be missing something. Any thoughts on this?
Cheers,
Michael
Attachments (1)
Change History (7)
Changed 13 years ago by
comment:1 Changed 13 years ago by
- Summary changed from bug in SymmetricGroup(1).cayley_graph() to [with patch, needs easy review] bug in SymmetricGroup(1).cayley_graph()
comment:2 Changed 13 years ago by
Conclusion:
The function cayley_graph
was unnecessarily complicated.
comment:3 Changed 13 years ago by
the patch looks good to me. I didn't apply or doctest it, though.
comment:4 Changed 13 years ago by
- Summary changed from [with patch, needs easy review] bug in SymmetricGroup(1).cayley_graph() to [with patch, positive review (pending doctesting)] bug in SymmetricGroup(1).cayley_graph()
comment:5 Changed 13 years ago by
- Summary changed from [with patch, positive review (pending doctesting)] bug in SymmetricGroup(1).cayley_graph() to [with patch, positive review] bug in SymmetricGroup(1).cayley_graph()
Doctests pass with the patch applied.
Cheers,
Michael
comment:6 Changed 13 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged in Sage 3.0.1.rc0
Note: See
TracTickets for help on using
tickets.
Applied to sage-3.0 on my macbook: