Opened 5 years ago
Closed 5 years ago
#22844 closed enhancement (fixed)
Symbolic limit
Reported by:  rws  Owned by:  

Priority:  major  Milestone:  sage8.0 
Component:  symbolics  Keywords:  
Cc:  charpent  Merged in:  
Authors:  Ralf Stephan  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  ce95d01 (Commits, GitHub, GitLab)  Commit:  ce95d015a7073fb32743dfbeb184582ca3da1ce2 
Dependencies:  Stopgaps: 
Change History (15)
comment:1 Changed 5 years ago by
 Branch set to u/rws/symbolic_limit
comment:2 Changed 5 years ago by
 Commit set to 2f5a28f235a1b61cdb5c394bf5743d6c242afea6
 Status changed from new to needs_review
comment:3 Changed 5 years ago by
 Commit changed from 2f5a28f235a1b61cdb5c394bf5743d6c242afea6 to bd403fd911b32e4116125f12c51d1e0359e3e835
comment:4 Changed 5 years ago by
 Cc charpent added
comment:5 Changed 5 years ago by
 Status changed from needs_review to needs_work
Doctest failures in src/sage/calculus/calculus.py
.
comment:6 Changed 5 years ago by
The latex conversion would be easily fixed. However, the fails show that there is the problem that the limit function can have either 3 or 4 arguments, the latter with an additional direction. I don't think Sage can handle this at the moment without tuples as arguments like in hypergeometric
, and this would change the code substantially.
EDIT: it may be possible to use two functions; checks elsewhere would then have to be done with both. The Maxima interface would have to know about it.
comment:7 Changed 5 years ago by
Maybe it is excusable in this case to write a customized __call__
member, as long as it's an internally only used function.
comment:8 Changed 5 years ago by
 Commit changed from bd403fd911b32e4116125f12c51d1e0359e3e835 to bd0a226c693a793ada956d045ae898e88b271972
comment:9 Changed 5 years ago by
 Status changed from needs_work to needs_review
Much easier: nargs=0
does the trick. Please review.
comment:10 Changed 5 years ago by
Needs a rebase over the latest develop
.
comment:11 Changed 5 years ago by
 Commit changed from bd0a226c693a793ada956d045ae898e88b271972 to 14f26478d05e4c5cfda934a2757a56b5a9c3afed
Branch pushed to git repo; I updated commit sha1. New commits:
14f2647  Merge branch 'develop' into t/22844/symbolic_limit

comment:12 Changed 5 years ago by
 Commit changed from 14f26478d05e4c5cfda934a2757a56b5a9c3afed to ce95d015a7073fb32743dfbeb184582ca3da1ce2
Branch pushed to git repo; I updated commit sha1. New commits:
ce95d01  Merge branch 'develop' into t/22844/symbolic_limit

comment:13 Changed 5 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
LGTM.
comment:14 Changed 5 years ago by
Thanks.
comment:15 Changed 5 years ago by
 Branch changed from u/rws/symbolic_limit to ce95d015a7073fb32743dfbeb184582ca3da1ce2
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
22844:internal symbolic limit function