Opened 2 years ago

Closed 2 years ago

#30657 closed defect (fixed)

Fix up "sage -p"

Reported by: mkoeppe Owned by:
Priority: critical Milestone: sage-9.2
Component: build Keywords:
Cc: jhpalmieri, mjo Merged in:
Authors: Matthias Koeppe Reviewers: Michael Orlitzky
Report Upstream: N/A Work issues:
Branch: 8ee7ee2 (Commits, GitHub, GitLab) Commit: 8ee7ee29ea4686a968846df1621f52adcd8f4173
Dependencies: #29500 Stopgaps:

GitHub link to the corresponding issue


$ ./sage -p sagetex
Found local metadata for sagetex-3.5
Using cached file /Users/mkoeppe/s/sage/sage-rebasing/upstream/sagetex-3.5.tar.gz
mkdir: : No such file or directory
Error creating directory 

Change History (12)

comment:1 Changed 2 years ago by mkoeppe

Branch: u/mkoeppe/fix_up__sage__p_

comment:2 Changed 2 years ago by mkoeppe

Commit: 2e20f230c0ac0b24c14b04b180217db68a2b7278
Dependencies: #29500
Status: newneeds_review

Branch is on top of #29500 because it touches the same code

Last 10 new commits:

0a64674build/pkgs/gambit/ Install via bdist_wheel
ca58693build/pkgs/pillow/ Install via bdist_wheel
5a747c4build/bin/sage-pip-{install,uninstall}: Remove pip2 support
9ee2110build/bin/sage-dist-helpers: Also use $sudo for storing the wheel file
d7aac84src/doc/en/developer/packaging.rst: Update sdh_... documentation
9b7c7a0build/bin/sage-pip-{install,uninstall}: Fix typo in comment
4135e8bbuild/bin/sage-pip-install: Remove an outdated comment
f2e7075Merge tag '9.2.beta13' into t/29500/install_all_python_packages_via_pip_wheel__create_pep_503_simple_repository_for_wheels
bd0fd2fMerge branch 't/29500/install_all_python_packages_via_pip_wheel__create_pep_503_simple_repository_for_wheels' into t/30657/fix_up__sage__p_
2e20f23build/bin/sage-spkg: Move SAGE_SPKG_{INST,SCRIPTS,WHEELS} setting here from build/bin/install, make them relative to SAGE_INST_LOCAL

comment:3 Changed 2 years ago by mkoeppe

Cc: jhpalmieri mjo added

comment:4 Changed 2 years ago by mkoeppe

Authors: Matthias Koeppe

comment:5 Changed 2 years ago by mjo

Reviewers: Michael Orlitzky
Status: needs_reviewpositive_review

Looks OK I guess. The build/bin/sage-spkg script obviously needs these variables set, so it makes sense to move them "up" out of build/make/install where they are not used directly.

comment:6 Changed 2 years ago by mkoeppe


comment:7 Changed 2 years ago by vbraun

Status: positive_reviewneeds_work

Fails while building sage_conf-none for me... do incremental builds work?

comment:8 Changed 2 years ago by git

Commit: 2e20f230c0ac0b24c14b04b180217db68a2b72788ee7ee29ea4686a968846df1621f52adcd8f4173

Branch pushed to git repo; I updated commit sha1. New commits:

be2417cMerge tag '9.2.beta14' into t/30657/fix_up__sage__p_
8ee7ee2build/make/install: Set SAGE_SPKG_WHEELS also here so that script packages still work

comment:9 Changed 2 years ago by mkoeppe

Status: needs_workneeds_review

comment:10 Changed 2 years ago by mjo

Status: needs_reviewpositive_review

The new commit is reverted on the #29386 branch, but looks good for now.

comment:11 Changed 2 years ago by mkoeppe


comment:12 Changed 2 years ago by vbraun

Branch: u/mkoeppe/fix_up__sage__p_8ee7ee29ea4686a968846df1621f52adcd8f4173
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.