Opened 2 years ago

Closed 2 years ago

#30632 closed defect (fixed)

few easy internet doctests failures to fix

Reported by: slabbe Owned by:
Priority: major Milestone: sage-9.2
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Sébastien Labbé Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: a442fa9 (Commits, GitHub, GitLab) Commit: a442fa9c58e24af4240ae0f76178f9f30a3f03ff
Dependencies: Stopgaps:

Status badges

Description (last modified by slabbe)

With 9.2.beta13, the command

sage -tp --optional=sage,internet src/sage/misc/remote_file.py src/sage/databases/oeis.py src/sage/misc/package.py

gives

----------------------------------------------------------------------
sage -t --random-seed=0 src/sage/misc/remote_file.py  # 1 doctest failed
sage -t --random-seed=0 src/sage/databases/oeis.py  # 1 doctest failed
sage -t --random-seed=0 src/sage/misc/package.py  # 1 doctest failed
----------------------------------------------------------------------

Change History (5)

comment:1 Changed 2 years ago by slabbe

Description: modified (diff)

comment:2 Changed 2 years ago by slabbe

Authors: Sébastien Labbé
Branch: u/slabbe/30632
Commit: a442fa9c58e24af4240ae0f76178f9f30a3f03ff
Status: newneeds_review

New commits:

a442fa930632: fixing internet doctest failures

comment:3 Changed 2 years ago by chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

ok, merci

comment:4 Changed 2 years ago by slelievre

The "not pypi" url could be changed to

-        sage: pypi = 'http://this.is.not.pypi.com/'
+        sage: pypi = 'http://not-pypi.example.com/'

but the existing solution works fine.

Merci Sébastien pour la branche, et Frédéric pour le feu vert.

Last edited 2 years ago by slelievre (previous) (diff)

comment:5 Changed 2 years ago by vbraun

Branch: u/slabbe/30632a442fa9c58e24af4240ae0f76178f9f30a3f03ff
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.