Opened 2 years ago
Closed 2 years ago
#30631 closed defect (fixed)
fix R on macOS xcode 12
| Reported by: | dimpase | Owned by: | |
|---|---|---|---|
| Priority: | critical | Milestone: | sage-9.2 |
| Component: | packages: standard | Keywords: | |
| Cc: | mkoeppe, jhpalmieri, slelievre | Merged in: | |
| Authors: | Dima Pasechnik | Reviewers: | John Palmieri |
| Report Upstream: | Fixed upstream, but not in a stable release. | Work issues: | |
| Branch: | 376af90 (Commits, GitHub, GitLab) | Commit: | 376af9027af48a941ce7eece6d1873c102c7fbf8 |
| Dependencies: | Stopgaps: |
Status badges
Description
configure fails to find bzlib, as the test function misses #includes This is fixed upstream in the trunk (in Sept. 2020).
Change History (8)
comment:1 Changed 2 years ago by
| Authors: | → Dima Pasechnik |
|---|---|
| Branch: | → u/dimpase/build/homebrewbzip |
| Commit: | → 376af9027af48a941ce7eece6d1873c102c7fbf8 |
| Status: | new → needs_review |
comment:2 Changed 2 years ago by
| Cc: | mkoeppe jhpalmieri added |
|---|
comment:3 Changed 2 years ago by
This builds for me with Xcode 12. For what it's worth, the changes to .homebrew-build-env didn't have any effect for me since I don't have bzip2 installed via homebrew. Just using the system version seems to work fine.
comment:4 Changed 2 years ago by
OK, so then these changes to .homebrew-build-env are not needed in fact. I added them as I tried to get R to recognise bzip2, so I thought it might be a problem here.
comment:5 Changed 2 years ago by
On the other hand there is no harm in the modification of .homebrew-build-env - it merely make sure that if Homebrew's bzip2 is installed then in gets used.
comment:6 Changed 2 years ago by
| Reviewers: | → John Palmieri |
|---|---|
| Status: | needs_review → positive_review |
Sounds good.
comment:7 Changed 2 years ago by
| Cc: | slelievre added |
|---|---|
| Priority: | major → critical |
Marking as critical since it is needed for Xcode 12 support.
comment:8 Changed 2 years ago by
| Branch: | u/dimpase/build/homebrewbzip → 376af9027af48a941ce7eece6d1873c102c7fbf8 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
New commits:
backport configure fix from trunk, add bzip2 paths