Opened 2 years ago

Closed 2 years ago

#30631 closed defect (fixed)

fix R on macOS xcode 12

Reported by: Dima Pasechnik Owned by:
Priority: critical Milestone: sage-9.2
Component: packages: standard Keywords:
Cc: Matthias Köppe, John Palmieri, Samuel Lelièvre Merged in:
Authors: Dima Pasechnik Reviewers: John Palmieri
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: 376af90 (Commits, GitHub, GitLab) Commit: 376af9027af48a941ce7eece6d1873c102c7fbf8
Dependencies: Stopgaps:

Status badges

Description

configure fails to find bzlib, as the test function misses #includes This is fixed upstream in the trunk (in Sept. 2020).

Change History (8)

comment:1 Changed 2 years ago by Dima Pasechnik

Authors: Dima Pasechnik
Branch: u/dimpase/build/homebrewbzip
Commit: 376af9027af48a941ce7eece6d1873c102c7fbf8
Status: newneeds_review

New commits:

376af90backport configure fix from trunk, add bzip2 paths

comment:2 Changed 2 years ago by Dima Pasechnik

Cc: Matthias Köppe John Palmieri added

comment:3 Changed 2 years ago by John Palmieri

This builds for me with Xcode 12. For what it's worth, the changes to .homebrew-build-env didn't have any effect for me since I don't have bzip2 installed via homebrew. Just using the system version seems to work fine.

comment:4 Changed 2 years ago by Dima Pasechnik

OK, so then these changes to .homebrew-build-env are not needed in fact. I added them as I tried to get R to recognise bzip2, so I thought it might be a problem here.

comment:5 Changed 2 years ago by Dima Pasechnik

On the other hand there is no harm in the modification of .homebrew-build-env - it merely make sure that if Homebrew's bzip2 is installed then it gets used.

Last edited 2 years ago by Dima Pasechnik (previous) (diff)

comment:6 Changed 2 years ago by John Palmieri

Reviewers: John Palmieri
Status: needs_reviewpositive_review

Sounds good.

comment:7 Changed 2 years ago by Samuel Lelièvre

Cc: Samuel Lelièvre added
Priority: majorcritical

Marking as critical since it is needed for Xcode 12 support.

comment:8 Changed 2 years ago by Volker Braun

Branch: u/dimpase/build/homebrewbzip376af9027af48a941ce7eece6d1873c102c7fbf8
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.