Opened 2 years ago

Closed 2 years ago

#30610 closed defect (fixed)

Fix openblas to build with Xcode 12

Reported by: John Palmieri Owned by:
Priority: critical Milestone: sage-9.2
Component: packages: standard Keywords:
Cc: Matthias Köppe, John Palmieri Merged in:
Authors: Dima Pasechnik Reviewers: John Palmieri
Report Upstream: None of the above - read trac for reasoning. Work issues:
Branch: b4315c2 (Commits, GitHub, GitLab) Commit: b4315c2b2286a34ab72ff982a49ddbdc4bb6d3d0
Dependencies: Stopgaps:

Status badges

Description (last modified by Dima Pasechnik)

OpenBLAS fails to build with Xcode 12 (as can be seen for example in https://github.com/mkoeppe/sage/runs/1141519170). The fix at https://github.com/xianyi/OpenBLAS/issues/2805, more precisely, https://github.com/xianyi/OpenBLAS/pull/2808 - and can be backported to 0.3.9 or 0.3.10.

This is marked critical, not a blocker, since there is a workable homebrew package that can be used instead.

Change History (7)

comment:1 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:2 Changed 2 years ago by Dima Pasechnik

Description: modified (diff)

comment:3 Changed 2 years ago by Dima Pasechnik

see https://github.com/xianyi/OpenBLAS/issues/2805#issuecomment-696710923

applying a patch to OpenBLAS's lapack.h allows one to build version 0.3.9

comment:4 Changed 2 years ago by Dima Pasechnik

Authors: Dima Pasechnik
Branch: u/dimpase/packages/openblas/xcode12patch
Commit: b4315c2b2286a34ab72ff982a49ddbdc4bb6d3d0
Report Upstream: N/ANone of the above - read trac for reasoning.
Status: newneeds_review

New commits:

b4315c2backport of the relevant part of upstream PR 2808

comment:5 Changed 2 years ago by Dima Pasechnik

Cc: Matthias Köppe John Palmieri added

comment:6 Changed 2 years ago by John Palmieri

Reviewers: John Palmieri
Status: needs_reviewpositive_review

This works for me.

comment:7 Changed 2 years ago by Volker Braun

Branch: u/dimpase/packages/openblas/xcode12patchb4315c2b2286a34ab72ff982a49ddbdc4bb6d3d0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.