Opened 7 months ago

Closed 6 months ago

#30608 closed defect (duplicate)

fix symmetrica for xcode 12

Reported by: dimpase Owned by:
Priority: blocker Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: mkoeppe, jhpalmieri, mjo Merged in:
Authors: Dima Pasechnik Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: u/dimpase/packages/symmetrica/xcode12fix (Commits, GitHub, GitLab) Commit: dfa4ab4ef70549263ff3b243ea30e38425ac6231
Dependencies: Stopgaps:

Status badges

Description


Change History (17)

comment:1 Changed 7 months ago by dimpase

  • Branch set to u/dimpase/packages/symmetrica/xcode12fix
  • Cc mkoeppe jhpalmieri added
  • Commit set to dfa4ab4ef70549263ff3b243ea30e38425ac6231
  • Status changed from new to needs_review

New commits:

dfa4ab4xcode12 fixes for symmetrica

comment:2 Changed 7 months ago by dimpase

this builds.

comment:3 Changed 7 months ago by dimpase

spkg.rst should be updated - some links are broken.

comment:4 Changed 7 months ago by jhpalmieri

I just saw one broken link. Should I push this change?

  • build/pkgs/symmetrica/SPKG.rst

    diff --git a/build/pkgs/symmetrica/SPKG.rst b/build/pkgs/symmetrica/SPKG.rst
    index bd82eda45f..3d0213ddba 100644
    a b University of Bayreuth. It has routines to handle the following topics 
    1818-  operations of finite groups.
    1919-  ordinary representation theory of Hecke algebras of type A_n
    2020
    21 For more details check http://www.symmetrica.de (currently redirects to
    22 http://www.algorithm.uni-bayreuth.de/en/research/SYMMETRICA)
     21For more details check
     22http://www.algorithm.uni-bayreuth.de/en/research/SYMMETRICA.
    2323
    2424License
    2525-------

comment:5 Changed 7 months ago by mkoeppe

  • Cc mjo added

See also: #29061 Upgrade to symmetrica-3.0.1

comment:6 follow-up: Changed 7 months ago by mjo

Just upgrade it, our forked upstream version is far ahead. I'd like to make a 3.0.2 release sometime soon with the pkg-config file, too. Additional brain power (and maybe German language skills) would be helpful on https://gitlab.com/sagemath/symmetrica/-/merge_requests/3 which is the only remaining item that I have no idea what to do with.

comment:7 in reply to: ↑ 6 ; follow-up: Changed 7 months ago by jhpalmieri

Replying to mjo:

Just upgrade it, our forked upstream version is far ahead.

Please prepare a branch at #29061 for us to test.

comment:8 in reply to: ↑ 7 Changed 7 months ago by dimpase

Replying to jhpalmieri:

Replying to mjo:

Just upgrade it, our forked upstream version is far ahead.

Please prepare a branch at #29061 for us to test.

I've posted a branch on #29061 it looks more attractive than this one, for sure.

comment:9 Changed 7 months ago by jhpalmieri

We should use either this one or #29061, but not both. (For example, I think that #29061 merges cleanly on top of this one, but then the patch here does not apply to the 3.0.1 tarball.) Both are marked as blockers. Which route should we take? My preference would be: if we can test #29061 on a lot of platforms quickly, we do that. If we can't, then let's use this one now and #29061 in the next release.

comment:10 Changed 7 months ago by dimpase

  • Milestone changed from sage-9.2 to sage-duplicate/invalid/wontfix

let's go with #29061 then, OK?

comment:11 Changed 7 months ago by jhpalmieri

Okay with me.

comment:12 Changed 7 months ago by jhpalmieri

But I'm not going to mark this as positive review until that one is ready. No need to close this one yet.

comment:13 Changed 7 months ago by mkoeppe

  • Authors Dima Pasechnik deleted
  • Reviewers set to John Palmieri

comment:14 Changed 7 months ago by dimpase

  • Authors set to Dima Pasechnik

comment:15 Changed 7 months ago by dimpase

as #29061 is ready, this one can get a positive review IMHO.

comment:16 Changed 7 months ago by jhpalmieri

  • Status changed from needs_review to positive_review

Okay, we can always return to it if we absolutely need to.

comment:17 Changed 6 months ago by chapoton

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.