Opened 2 years ago

Closed 2 years ago

#30604 closed defect (fixed)

fix scipy for XCode 12

Reported by: Dima Pasechnik Owned by:
Priority: blocker Milestone: sage-9.2
Component: packages: standard Keywords:
Cc: Matthias Köppe, John Palmieri Merged in:
Authors: Dima Pasechnik Reviewers: John Palmieri
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: 711fe05 (Commits, GitHub, GitLab) Commit: 711fe05025795e44b84233e065d240859ccae5bd
Dependencies: Stopgaps:

Status badges

Description


Attachments (1)

scipy-test-failure.txt (6.9 KB) - added by Dave Morris 2 years ago.
failure report

Download all attachments as: .zip

Change History (14)

comment:1 Changed 2 years ago by Dima Pasechnik

Branch: u/dimpase/packages/scipy/xcode12fix
Cc: Matthias Köppe John Palmieri added
Commit: 711fe05025795e44b84233e065d240859ccae5bd
Status: newneeds_review

upstream already have some of these fixes in master, but not all.


New commits:

711fe05missing extern decls and #include statements for scipy on xcode12

comment:2 Changed 2 years ago by Dima Pasechnik

PR for the upstream master branch: https://github.com/scipy/scipy/pull/12864

comment:3 Changed 2 years ago by John Palmieri

Reviewers: John Palmieri
Status: needs_reviewpositive_review

The changes look sensible, I don't imagine them causing breakage on other platforms, and scipy now builds for me with Xcode 12.

comment:4 Changed 2 years ago by Matthias Köppe

Priority: majorblocker

comment:5 Changed 2 years ago by Dima Pasechnik

Report Upstream: Reported upstream. No feedback yet.Fixed upstream, in a later stable release.

our PR is accepted upstream.

Do you know if Sage's scipy passed its tests on macOS before ? It does not in this configuration.

comment:6 Changed 2 years ago by John Palmieri

It seems that when I checked a year ago, it did pass its test suite.

comment:7 Changed 2 years ago by John Palmieri

Actually, sorry, I misunderstood. I don't know if I've ever run scipy's tests: I typically only run tests using the spkg-check files in Sage (via SAGE_CHECK=yes), and scipy doesn't have one of those. So I didn't run its tests a year ago.

comment:8 Changed 2 years ago by Dima Pasechnik

One can fire up Python and do

>>> import scipy
>>> scipy.test()

for a relatively short testsuite. (It requires pytest installed).

comment:9 Changed 2 years ago by John Palmieri

I don't have any machine with Xcode 11 to test with, unfortunately.

comment:10 Changed 2 years ago by Zachary L Scherr

I also don't have Xcode 11 any more, but my systemwide scipy on Mac and ubuntu both have similar numbers:

Ubuntu 20.04:

============================ 25461 passed, 2015 skipped, 10989 deselected, 75 xfailed, 7 xpassed, 10 warnings in 459.37s (0:07:39) =============================

Mac 10.15, Xcode 12

============================ 25497 passed, 1980 skipped, 10989 deselected, 75 xfailed, 6 xpassed, 10 warnings in 398.20s (0:06:38) =============================

Changed 2 years ago by Dave Morris

Attachment: scipy-test-failure.txt added

failure report

comment:11 Changed 2 years ago by Dave Morris

In case it's any help: I ran scipy.test() inside sage (or, at least, I think that's what I did) and I seemed to get only one failure. It seems to be in test_hyperu_around_0 in test_mpmath.py. (The failure report from the end of the run is attached as scipy-test-failure.txt.) This is sage 9.2b12 on Mac OS 10.15.6. I think my XCode version is 11.0.

comment:12 Changed 2 years ago by Dima Pasechnik

That Xcode 12 update raises the question whether the clang-12 - compiled code meant to be compatible with the clang-11 - compiled code, in particular C++ might be an issue.

comment:13 Changed 2 years ago by Volker Braun

Branch: u/dimpase/packages/scipy/xcode12fix711fe05025795e44b84233e065d240859ccae5bd
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.