Opened 2 years ago

Closed 2 years ago

#30603 closed enhancement (fixed)

Upgrade readline to 8.0

Reported by: John Palmieri Owned by:
Priority: critical Milestone: sage-9.2
Component: packages: standard Keywords:
Cc: Erik Bray Merged in:
Authors: John Palmieri Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 3e7b084 (Commits, GitHub, GitLab) Commit: 3e7b0845282a396727ef1adcf0d113c38d6eea34
Dependencies: Stopgaps:

Status badges

Change History (9)

comment:1 Changed 2 years ago by John Palmieri

Authors: John Palmieri
Description: modified (diff)
Status: newneeds_review

The file sigsetjmp.patch doesn't apply anymore, so I removed it. The new version needs to be tested on various platforms, including cygwin (which is what this patch was for, apparently).

comment:2 Changed 2 years ago by John Palmieri

Branch: u/jhpalmieri/readline-8.0

comment:3 Changed 2 years ago by git

Commit: 3e7b0845282a396727ef1adcf0d113c38d6eea34

Branch pushed to git repo; I updated commit sha1. New commits:

3e7b084readline: add upstream_url field

comment:4 Changed 2 years ago by Matthias Köppe

Cc: Erik Bray added

comment:5 Changed 2 years ago by John Palmieri

Priority: blockercritical

Marking as critical since there is a working homebrew package that can be used in place of Sage's readline.

comment:6 Changed 2 years ago by Matthias Köppe

Reviewers: Matthias Koeppe
Status: needs_reviewpositive_review

This seems to work well, as tested for example in https://github.com/mkoeppe/sage/actions/runs/268683330

comment:7 Changed 2 years ago by Matthias Köppe

(The package builds correctly on cygwin-minimal (https://github.com/mkoeppe/sage/runs/1154771531).)

comment:8 in reply to:  7 Changed 2 years ago by John Palmieri

Replying to mkoeppe:

(The package builds correctly on cygwin-minimal (https://github.com/mkoeppe/sage/runs/1154771531).)

Great, thank you for checking that!

comment:9 Changed 2 years ago by Volker Braun

Branch: u/jhpalmieri/readline-8.03e7b0845282a396727ef1adcf0d113c38d6eea34
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.