Opened 2 years ago
Closed 2 years ago
#30598 closed enhancement (fixed)
Define a new data structure for a combinatorial face
Reported by:  ghkliem  Owned by:  

Priority:  major  Milestone:  sage9.3 
Component:  geometry  Keywords:  combinatorial face, bitset 
Cc:  Travis Scrimshaw  Merged in:  
Authors:  Jonathan Kliem  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  bb33866 (Commits, GitHub, GitLab)  Commit:  bb3386679619b91dd9b02718025d1331cc9ed3cb 
Dependencies:  #30601  Stopgaps: 
Description
We define a new data structure for a combinatorial face that accesses the underlying bitset functions.
See #30549 for doctesting.
Change History (12)
comment:1 Changed 2 years ago by
Cc:  Travis Scrimshaw added 

Status:  new → needs_review 
comment:2 Changed 2 years ago by
Milestone:  sage9.2 → sage9.3 

comment:3 Changed 2 years ago by
Commit:  e421d300d7d44fb655251fa8178a87074024d296 → c9ba96bde4dda10c676ffbfc15e55d22b4f70591 

comment:4 Changed 2 years ago by
Commit:  c9ba96bde4dda10c676ffbfc15e55d22b4f70591 → a369269092be18e407d994438599b8577a1eedb6 

comment:5 Changed 2 years ago by
Dependencies:  #30597 → #30601 

comment:6 Changed 2 years ago by
Commit:  a369269092be18e407d994438599b8577a1eedb6 → bb3386679619b91dd9b02718025d1331cc9ed3cb 

Branch pushed to git repo; I updated commit sha1. New commits:
bb33866  import instead of include

comment:7 Changed 2 years ago by
This pure C code is not used anywhere... it is a strange looking ticket.
comment:8 Changed 2 years ago by
I know.
#30549 is a patchbomb already and I'm trying to make it as easy as possible. Everything is used in there. The idea was to outsource stuff that can be easily reviewed.
One could of course add a pyx
file solely that tries to test things.
comment:9 Changed 2 years ago by
Reviewers:  → Travis Scrimshaw 

Status:  needs_review → positive_review 
LGTM.
comment:10 Changed 2 years ago by
Thank you.
Btw, at some point soon, I will have to move this file again, as there is at least two other places in sage that can use this algorithm. This might involve some renaming.
Maybe it might be a good idea to do this now and reopen this ticket. What do you think?
comment:11 Changed 2 years ago by
I think it is fine on a separate ticket, perhaps just when you do that move.
comment:12 Changed 2 years ago by
Branch:  u/ghkliem/data_structure_for_combinatorial_face → bb3386679619b91dd9b02718025d1331cc9ed3cb 

Resolution:  → fixed 
Status:  positive_review → closed 
Branch pushed to git repo; I updated commit sha1. New commits:
put imports in order