Opened 2 years ago

Closed 2 years ago

#30598 closed enhancement (fixed)

Define a new data structure for a combinatorial face

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.3
Component: geometry Keywords: combinatorial face, bitset
Cc: Travis Scrimshaw Merged in:
Authors: Jonathan Kliem Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: bb33866 (Commits, GitHub, GitLab) Commit: bb3386679619b91dd9b02718025d1331cc9ed3cb
Dependencies: #30601 Stopgaps:

Status badges

Description

We define a new data structure for a combinatorial face that accesses the underlying bitset functions.

See #30549 for doctesting.

Change History (12)

comment:1 Changed 2 years ago by gh-kliem

Cc: Travis Scrimshaw added
Status: newneeds_review

comment:2 Changed 2 years ago by gh-kliem

Milestone: sage-9.2sage-9.3

comment:3 Changed 2 years ago by git

Commit: e421d300d7d44fb655251fa8178a87074024d296c9ba96bde4dda10c676ffbfc15e55d22b4f70591

Branch pushed to git repo; I updated commit sha1. New commits:

c9ba96bput imports in order

comment:4 Changed 2 years ago by git

Commit: c9ba96bde4dda10c676ffbfc15e55d22b4f70591a369269092be18e407d994438599b8577a1eedb6

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d5e06fdmove bitset.pxi to proper header file
a31fb27new data structure for a combinatorial face of a polyhedron
a369269put imports in order

comment:5 Changed 2 years ago by gh-kliem

Dependencies: #30597#30601

comment:6 Changed 2 years ago by git

Commit: a369269092be18e407d994438599b8577a1eedb6bb3386679619b91dd9b02718025d1331cc9ed3cb

Branch pushed to git repo; I updated commit sha1. New commits:

bb33866import instead of include

comment:7 Changed 2 years ago by Vincent Delecroix

This pure C code is not used anywhere... it is a strange looking ticket.

comment:8 Changed 2 years ago by gh-kliem

I know.

#30549 is a patchbomb already and I'm trying to make it as easy as possible. Everything is used in there. The idea was to outsource stuff that can be easily reviewed.

One could of course add a pyx file solely that tries to test things.

comment:9 Changed 2 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:10 Changed 2 years ago by gh-kliem

Thank you.

Btw, at some point soon, I will have to move this file again, as there is at least two other places in sage that can use this algorithm. This might involve some renaming.

Maybe it might be a good idea to do this now and reopen this ticket. What do you think?

comment:11 Changed 2 years ago by Travis Scrimshaw

I think it is fine on a separate ticket, perhaps just when you do that move.

comment:12 Changed 2 years ago by Volker Braun

Branch: u/gh-kliem/data_structure_for_combinatorial_facebb3386679619b91dd9b02718025d1331cc9ed3cb
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.