Opened 2 years ago

Closed 2 years ago

#30595 closed enhancement (fixed)

Remove deprecated sage.libs.ppl

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.2
Component: refactoring Keywords:
Cc: Vincent Delecroix, Jean-Philippe Labbé, gh-kliem, Travis Scrimshaw, Frédéric Chapoton Merged in:
Authors: Matthias Koeppe Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 8c51242 (Commits, GitHub, GitLab) Commit: 8c512429644fa77462cb2bb0a84762c3ae2f02b0
Dependencies: Stopgaps:

Status badges

Description

In #23024 (merged in Sage 8.7), sage.libs.ppl was deprecated and all uses converted to using the standalone library pplpy.

We remove the deprecated library.

Change History (10)

comment:1 Changed 2 years ago by Matthias Köppe

Branch: u/mkoeppe/remove_deprecated_sage_libs_ppl

comment:2 Changed 2 years ago by Matthias Köppe

Authors: Matthias Koeppe
Branch: u/mkoeppe/remove_deprecated_sage_libs_ppl
Status: newneeds_review

comment:3 Changed 2 years ago by John Palmieri

The branch was deleted?

comment:4 Changed 2 years ago by Matthias Köppe

Branch: u/mkoeppe/remove_deprecated_sage_libs_ppl

comment:5 Changed 2 years ago by Matthias Köppe

Commit: 27de60f05954ec740628a1d27e653a3fc0853c9c

Now it's back


New commits:

27de60fsage.libs.ppl: Remove

comment:6 Changed 2 years ago by gh-kliem

Documentation doesn't build:

[dochtml] Error building the documentation.
[dochtml] Traceback (most recent call last):
[dochtml]   File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
[dochtml]     "__main__", mod_spec)
[dochtml]   File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
[dochtml]     exec(code, run_globals)
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__main__.py", line 2, in <module>
[dochtml]     main()
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 1730, in main
[dochtml]     builder()
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 344, in _wrapper
[dochtml]     getattr(get_builder(document), 'inventory')(*args, **kwds)
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 570, in _wrapper
[dochtml]     self._build_everything_except_bibliography(lang, format, *args, **kwds)
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 556, in _build_everything_except_bibliography
[dochtml]     build_many(build_ref_doc, non_references)
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 296, in build_many
[dochtml]     _build_many(target, args, processes=NUM_THREADS)
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/utils.py", line 289, in build_many
[dochtml]     raise worker_exc.original_exception
[dochtml] OSError: WARNING: autodoc: failed to import module 'ppl' from module 'sage.libs'; the following exception was raised:

comment:7 Changed 2 years ago by Sébastien Labbé

Branch: u/mkoeppe/remove_deprecated_sage_libs_pplpublic/30595
Commit: 27de60f05954ec740628a1d27e653a3fc0853c9c8c512429644fa77462cb2bb0a84762c3ae2f02b0

Added a small commit which removes sage/libs/ppl from the doc.


New commits:

8c5124230595: remove sage/libs/ppl from doc

comment:8 Changed 2 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

looks good.

comment:9 Changed 2 years ago by Matthias Köppe

Thanks!

comment:10 Changed 2 years ago by Volker Braun

Branch: public/305958c512429644fa77462cb2bb0a84762c3ae2f02b0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.