#30579 closed enhancement (fixed)

Clean up sage_setup.library_order

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-9.3
Component: build Keywords:
Cc: jhpalmieri, fbissey, dimpase Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 49cd771 (Commits, GitHub, GitLab) Commit: 49cd7710dcf8ae7cc86924b7726f9e8163ae546a
Dependencies: Stopgaps:

Status badges

Description

Follow-up from #29702, #29706:

We remove code that duplicated the function of sage.env.cython_aliases

Change History (12)

comment:1 Changed 16 months ago by mkoeppe

  • Branch set to u/mkoeppe/clean_up_sage_setup_library_order

comment:2 Changed 16 months ago by mkoeppe

  • Commit set to eb8db08941ca0532e259b9cf8af9b2994aea7a0b
  • Status changed from new to needs_review

New commits:

eb8db08src/sage_setup/library_order.py: Get library lists from sage.env.cython_aliases

comment:3 Changed 15 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:4 Changed 15 months ago by mkoeppe

  • Cc dimpase added

comment:5 Changed 15 months ago by git

  • Commit changed from eb8db08941ca0532e259b9cf8af9b2994aea7a0b to 3fca461cc083af48970ff671ca07a2f223bf485a

Branch pushed to git repo; I updated commit sha1. New commits:

43966d6Merge tag '9.3.beta0' into t/30579/clean_up_sage_setup_library_order
3fca461src/sage_setup/library_order.py: Remove unused import

comment:6 Changed 15 months ago by mkoeppe

Needs review

comment:7 Changed 15 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

ok, this works

comment:8 Changed 15 months ago by mkoeppe

Thanks!

comment:9 Changed 14 months ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:10 Changed 14 months ago by git

  • Commit changed from 3fca461cc083af48970ff671ca07a2f223bf485a to 49cd7710dcf8ae7cc86924b7726f9e8163ae546a

Branch pushed to git repo; I updated commit sha1. New commits:

49cd771Merge tag '9.3.beta2' into t/30579/clean_up_sage_setup_library_order

comment:11 Changed 14 months ago by mkoeppe

  • Status changed from needs_work to positive_review

comment:12 Changed 14 months ago by vbraun

  • Branch changed from u/mkoeppe/clean_up_sage_setup_library_order to 49cd7710dcf8ae7cc86924b7726f9e8163ae546a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.