Opened 2 years ago

Closed 2 years ago

#30579 closed enhancement (fixed)

Clean up sage_setup.library_order

Reported by: Matthias Köppe Owned by:
Priority: minor Milestone: sage-9.3
Component: build Keywords:
Cc: John Palmieri, François Bissey, Dima Pasechnik Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 49cd771 (Commits, GitHub, GitLab) Commit: 49cd7710dcf8ae7cc86924b7726f9e8163ae546a
Dependencies: Stopgaps:

Status badges

Description

Follow-up from #29702, #29706:

We remove code that duplicated the function of sage.env.cython_aliases

Change History (12)

comment:1 Changed 2 years ago by Matthias Köppe

Branch: u/mkoeppe/clean_up_sage_setup_library_order

comment:2 Changed 2 years ago by Matthias Köppe

Commit: eb8db08941ca0532e259b9cf8af9b2994aea7a0b
Status: newneeds_review

New commits:

eb8db08src/sage_setup/library_order.py: Get library lists from sage.env.cython_aliases

comment:3 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.2sage-9.3

comment:4 Changed 2 years ago by Matthias Köppe

Cc: Dima Pasechnik added

comment:5 Changed 2 years ago by git

Commit: eb8db08941ca0532e259b9cf8af9b2994aea7a0b3fca461cc083af48970ff671ca07a2f223bf485a

Branch pushed to git repo; I updated commit sha1. New commits:

43966d6Merge tag '9.3.beta0' into t/30579/clean_up_sage_setup_library_order
3fca461src/sage_setup/library_order.py: Remove unused import

comment:6 Changed 2 years ago by Matthias Köppe

Needs review

comment:7 Changed 2 years ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

ok, this works

comment:8 Changed 2 years ago by Matthias Köppe

Thanks!

comment:9 Changed 2 years ago by Volker Braun

Status: positive_reviewneeds_work

Merge conflict

comment:10 Changed 2 years ago by git

Commit: 3fca461cc083af48970ff671ca07a2f223bf485a49cd7710dcf8ae7cc86924b7726f9e8163ae546a

Branch pushed to git repo; I updated commit sha1. New commits:

49cd771Merge tag '9.3.beta2' into t/30579/clean_up_sage_setup_library_order

comment:11 Changed 2 years ago by Matthias Köppe

Status: needs_workpositive_review

comment:12 Changed 2 years ago by Volker Braun

Branch: u/mkoeppe/clean_up_sage_setup_library_order49cd7710dcf8ae7cc86924b7726f9e8163ae546a
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.