Opened 9 months ago

Closed 6 months ago

#30571 closed enhancement (invalid)

Remove doctests in `combinatorial_polyhedron/conversions.pyx` that depend on implementation details

Reported by: gh-kliem Owned by:
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: geometry Keywords:
Cc: jipilab, gh-LaisRast, tscrim Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

We remove doctests that depend on implementation of the bitsets and exchange those by tests that check that conversion back and forth works correctly.

In addition we remove the deprecation warnings from #28608 in this file. Those functions aren't meant for public use anyway and the old names were exposed for a rather short period (sage 8.9 and sage 9.0).

Change History (6)

comment:1 Changed 9 months ago by gh-kliem

  • Branch set to u/gh-kliem/prepare_conversions_for_face_structure
  • Cc jipilab gh-LaisRast tscrim added
  • Commit set to af27e0256bc049fe6046df6fc2a69789c8b00ddf
  • Status changed from new to needs_review

Last 10 new commits:

fc8124afix mistake
3e30d07add doctest functions for combinatorial_polyhedron/conversions.pyx
41ed120simplify doctest in list_of_faces
1529987simplify doctessts in polyhedron face lattice
7b134d5Merge branch 'u/gh-kliem/simplify_conversion_tests' of git://trac.sagemath.org/sage into u/gh-kliem/no_more_basic_access_2
072e200temporary commit
cba37e8temporary commit
0b41c77remove basic acces to bitsets
7a32286removed deprecated functions
af27e02remove doctests that rely on implementation details

comment:2 Changed 9 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 9 months ago by gh-kliem

Thank you.

comment:4 Changed 7 months ago by gh-kliem

  • Milestone changed from sage-9.3 to sage-duplicate/invalid/wontfix
  • Status changed from positive_review to needs_review

With #30528 gone, it's hard to make this work on it's own.

comment:5 Changed 7 months ago by tscrim

  • Authors Jonathan Kliem deleted
  • Branch u/gh-kliem/prepare_conversions_for_face_structure deleted
  • Commit af27e0256bc049fe6046df6fc2a69789c8b00ddf deleted
  • Dependencies #30528 deleted
  • Status changed from needs_review to positive_review

comment:6 Changed 6 months ago by chapoton

  • Resolution set to invalid
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.