Opened 2 years ago
Closed 2 years ago
#30562 closed defect (fixed)
Gap downloads from wrong upstream directory
Reported by:  vbraun  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  packages: standard  Keywords:  
Cc:  dimpase  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  6b05519 (Commits, GitHub, GitLab)  Commit:  6b0551918aa66216cf167ddb512b89d41641455c 
Dependencies:  Stopgaps: 
Description
It should download $HOST/upstream/gap/gap4.11.0.tar.bz2, but goes for /upstream/gap_packages/ instead:
[gap4.11.0.p0] Found local metadata for gap4.11.0.p0 [gap4.11.0.p0] Attempting to download package gap4.11.0.tar.bz2 from mirrors [gap4.11.0.p0] http://sagepad.org/spkg/upstream/gap_packages/gap4.11.0.tar.bz2 [gap4.11.0.p0] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx] [gap4.11.0.p0] ERROR [transferrun:135]: [Errno 404] Not Found: '//sagepad.org/spkg/upstream/gap_packages/gap4.11.0.tar.bz2' [gap4.11.0.p0] https://mirror.koddos.net/sagemath/spkg/upstream/gap_packages/gap4.11.0.tar.bz2 [gap4.11.0.p0] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx] [gap4.11.0.p0] ERROR [transferrun:135]: [Errno 404] Not Found: '//mirror.koddos.net/sagemath/spkg/upstream/gap_packages/gap4.11.0.tar.bz2' [gap4.11.0.p0] http://www.mirrorservice.org/sites/www.sagemath.org/spkg/upstream/gap_packages/gap4.11.0.tar.bz2
For now I'm manually copying the gap tarball to /gap_packages/, but would be nice to get this fixed.
Change History (7)
comment:1 Changed 2 years ago by
Milestone:  sage9.2 → sageduplicate/invalid/wontfix 

Status:  new → needs_review 
comment:2 Changed 2 years ago by
Except that #29314 is hit by a swarm of open cans of worms. Makes me willing to redo the Sage's docbuild using the standard modern sphinx, I don't care if it will get slower.
comment:3 Changed 2 years ago by
Branch:  → u/mkoeppe/gap_downloads_from_wrong_upstream_directory 

comment:4 Changed 2 years ago by
Authors:  → Matthias Koeppe 

Commit:  → 6b0551918aa66216cf167ddb512b89d41641455c 
Milestone:  sageduplicate/invalid/wontfix → sage9.2 
New commits:
6b05519  build/pkgs/gap_packages: Use symlinks to refer to gap's tarball

comment:5 Changed 2 years ago by
Reviewers:  → Dima Pasechnik 

Status:  needs_review → positive_review 
It works if I already have the GAP tarball in upstream. I believe it's usually will be the case, as gap is a dependency of gap_packages, thus the tarball will be fetched for gap, if gap is not installed.
I've also tested that removing the tarball from upstream triggers its downloading if gap is already installed, but gap_packages is not.
So, all good.
comment:7 Changed 2 years ago by
Branch:  u/mkoeppe/gap_downloads_from_wrong_upstream_directory → 6b0551918aa66216cf167ddb512b89d41641455c 

Resolution:  → fixed 
Status:  positive_review → closed 
Fixed this in #29314 by using symlinks instead of duplicating the checksums.ini file