Opened 2 years ago

Closed 2 years ago

#30562 closed defect (fixed)

Gap downloads from wrong upstream directory

Reported by: vbraun Owned by:
Priority: major Milestone: sage-9.2
Component: packages: standard Keywords:
Cc: dimpase Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 6b05519 (Commits, GitHub, GitLab) Commit: 6b0551918aa66216cf167ddb512b89d41641455c
Dependencies: Stopgaps:

Status badges

Description

It should download $HOST/upstream/gap/gap-4.11.0.tar.bz2, but goes for /upstream/gap_packages/ instead:

[gap-4.11.0.p0] Found local metadata for gap-4.11.0.p0
[gap-4.11.0.p0] Attempting to download package gap-4.11.0.tar.bz2 from mirrors
[gap-4.11.0.p0] http://sagepad.org/spkg/upstream/gap_packages/gap-4.11.0.tar.bz2
[gap-4.11.0.p0] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[gap-4.11.0.p0] ERROR [transfer|run:135]: [Errno 404] Not Found: '//sagepad.org/spkg/upstream/gap_packages/gap-4.11.0.tar.bz2'
[gap-4.11.0.p0] https://mirror.koddos.net/sagemath/spkg/upstream/gap_packages/gap-4.11.0.tar.bz2
[gap-4.11.0.p0] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[gap-4.11.0.p0] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirror.koddos.net/sagemath/spkg/upstream/gap_packages/gap-4.11.0.tar.bz2'
[gap-4.11.0.p0] http://www.mirrorservice.org/sites/www.sagemath.org/spkg/upstream/gap_packages/gap-4.11.0.tar.bz2

For now I'm manually copying the gap tarball to /gap_packages/, but would be nice to get this fixed.

Change History (7)

comment:1 Changed 2 years ago by mkoeppe

Milestone: sage-9.2sage-duplicate/invalid/wontfix
Status: newneeds_review

Fixed this in #29314 by using symlinks instead of duplicating the checksums.ini file

comment:2 Changed 2 years ago by dimpase

Except that #29314 is hit by a swarm of open cans of worms. Makes me willing to redo the Sage's docbuild using the standard modern sphinx, I don't care if it will get slower.

comment:3 Changed 2 years ago by mkoeppe

Branch: u/mkoeppe/gap_downloads_from_wrong_upstream_directory

comment:4 Changed 2 years ago by mkoeppe

Authors: Matthias Koeppe
Commit: 6b0551918aa66216cf167ddb512b89d41641455c
Milestone: sage-duplicate/invalid/wontfixsage-9.2

New commits:

6b05519build/pkgs/gap_packages: Use symlinks to refer to gap's tarball

comment:5 Changed 2 years ago by dimpase

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

It works if I already have the GAP tarball in upstream. I believe it's usually will be the case, as gap is a dependency of gap_packages, thus the tarball will be fetched for gap, if gap is not installed.

I've also tested that removing the tarball from upstream triggers its downloading if gap is already installed, but gap_packages is not.

So, all good.

comment:6 Changed 2 years ago by mkoeppe

Thanks.

comment:7 Changed 2 years ago by vbraun

Branch: u/mkoeppe/gap_downloads_from_wrong_upstream_directory6b0551918aa66216cf167ddb512b89d41641455c
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.