Opened 2 years ago

Closed 2 years ago

#30555 closed defect (fixed)

Incorrect gt() and lt() functions in Berkovich space

Reported by: Alexander Galarraga Owned by:
Priority: trivial Milestone: sage-9.3
Component: padics Keywords:
Cc: Ben Hutz, Paul Fili Merged in:
Authors: Alexander Galarraga Reviewers: Ben Hutz
Report Upstream: N/A Work issues:
Branch: 062ff67 (Commits, GitHub, GitLab) Commit: 062ff67f3d4b3c8a2a9c57d47d35c7ad41d96165
Dependencies: Stopgaps:

Status badges

Description

Currently, the gt() and lt() functions for points of Berkovich space over Cp treat infinity as a minimal Type I point:

sage: B = Berkovich_Cp_Projective(3)
sage: infinity = B((1,0))
sage: gauss = B(0,1)
sage: gauss.gt(infinity)
True

Infinity, however, is maximal with respect to the standard partial order. We fix this error.

Change History (6)

comment:1 Changed 2 years ago by Alexander Galarraga

Branch: u/gh-EnderWannabe/partial_order_fix

comment:2 Changed 2 years ago by git

Commit: 062ff67f3d4b3c8a2a9c57d47d35c7ad41d96165

Branch pushed to git repo; I updated commit sha1. New commits:

062ff6730555: initial fix with tests + small doc changes

comment:3 Changed 2 years ago by Alexander Galarraga

Status: newneeds_review

comment:4 Changed 2 years ago by Ben Hutz

Reviewers: Ben Hutz
Status: needs_reviewpositive_review

Works as expected.

comment:5 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.2sage-9.3

comment:6 Changed 2 years ago by Volker Braun

Branch: u/gh-EnderWannabe/partial_order_fix062ff67f3d4b3c8a2a9c57d47d35c7ad41d96165
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.