Opened 2 years ago
Closed 2 years ago
#30555 closed defect (fixed)
Incorrect gt() and lt() functions in Berkovich space
Reported by: | Alexander Galarraga | Owned by: | |
---|---|---|---|
Priority: | trivial | Milestone: | sage-9.3 |
Component: | padics | Keywords: | |
Cc: | Ben Hutz, Paul Fili | Merged in: | |
Authors: | Alexander Galarraga | Reviewers: | Ben Hutz |
Report Upstream: | N/A | Work issues: | |
Branch: | 062ff67 (Commits, GitHub, GitLab) | Commit: | 062ff67f3d4b3c8a2a9c57d47d35c7ad41d96165 |
Dependencies: | Stopgaps: |
Description
Currently, the gt() and lt() functions for points of Berkovich space over Cp treat infinity as a minimal Type I point:
sage: B = Berkovich_Cp_Projective(3) sage: infinity = B((1,0)) sage: gauss = B(0,1) sage: gauss.gt(infinity) True
Infinity, however, is maximal with respect to the standard partial order. We fix this error.
Change History (6)
comment:1 Changed 2 years ago by
Branch: | → u/gh-EnderWannabe/partial_order_fix |
---|
comment:2 Changed 2 years ago by
Commit: | → 062ff67f3d4b3c8a2a9c57d47d35c7ad41d96165 |
---|
comment:3 Changed 2 years ago by
Status: | new → needs_review |
---|
comment:4 Changed 2 years ago by
Reviewers: | → Ben Hutz |
---|---|
Status: | needs_review → positive_review |
Works as expected.
comment:5 Changed 2 years ago by
Milestone: | sage-9.2 → sage-9.3 |
---|
comment:6 Changed 2 years ago by
Branch: | u/gh-EnderWannabe/partial_order_fix → 062ff67f3d4b3c8a2a9c57d47d35c7ad41d96165 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
30555: initial fix with tests + small doc changes