Opened 2 years ago

Closed 2 years ago

#30545 closed defect (fixed)

A 1-dimensional polytope has no edge

Reported by: Vincent Pilaud Owned by:
Priority: minor Milestone: sage-9.3
Component: geometry Keywords: polytopes
Cc: Jean-Philippe Labbé, Frédéric Chapoton, gh-kliem Merged in:
Authors: Frédéric Chapoton Reviewers: Samuel Lelièvre
Report Upstream: N/A Work issues:
Branch: 4c3016a (Commits, GitHub, GitLab) Commit: 4c3016a60af07b5bbb5cf0b1f3e161cfdb648895
Dependencies: Stopgaps:

Status badges

Description (last modified by Samuel Lelièvre)

The graph of a polytope used to be constructed in the method graph using pairs of vertices satisfying common inequalities of the inequalities list, which did not work in dimension 1:

In Sage 9.0:

sage: polytopes.simplex(1).graph().edges()
[]

This has since been fixed.

This ticket adds a doctest.

Change History (13)

comment:1 Changed 2 years ago by Frédéric Chapoton

Cc: Jean-Philippe Labbé Frédéric Chapoton gh-kliem added; labbe@… chapoton@… removed
Milestone: sage-9.2sage-9.3

comment:2 Changed 2 years ago by Frédéric Chapoton

Vincent, tu utilises quelle version de sage ? Ca marche pour moi dans la version 9.2.beta12.

sage: polytopes.simplex(1).graph().edges()                                      
[(A vertex at (0, 1), A vertex at (1, 0), None)]
Last edited 2 years ago by Frédéric Chapoton (previous) (diff)

comment:3 Changed 2 years ago by gh-kliem

I cannot reproduce this either.

comment:4 Changed 2 years ago by Dima Pasechnik

by the way, I see bouncing emails from trac to vinc.pilaud@... (they seem to be notifications on this ticket).

Please alert vpilaud.

Yours, postmaster :-)

Last edited 2 years ago by Dima Pasechnik (previous) (diff)

comment:5 Changed 2 years ago by Vincent Pilaud

I had that on version 9.0 and was too lazy to update. So nevermind. I took the opportunity to update my email address on track.

comment:6 Changed 2 years ago by Samuel Lelièvre

Milestone: sage-9.3sage-duplicate/invalid/wontfix
Status: newneeds_info

Two ways to solve this ticket:

  • add a doctest for that (is there already one?)
  • or set to duplicate/invalid/wontfix

comment:7 Changed 2 years ago by Samuel Lelièvre

Cheap ways to check whether something is fixed in a more recent Sage version than you have:

  • The main CoCalc instance has a lot of Sage versions installed, including the last few stable versions, and usually a recent enough development version.

This can help decide whether to upgrade.

comment:8 Changed 2 years ago by Frédéric Chapoton

Authors: Frédéric Chapoton
Branch: u/chapoton/30545
Commit: 4c3016a60af07b5bbb5cf0b1f3e161cfdb648895
Status: needs_infoneeds_review

Here is a doctest


New commits:

4c3016aadd a check for the vertex graph af the line-segment polytope

comment:9 Changed 2 years ago by Samuel Lelièvre

Milestone: sage-duplicate/invalid/wontfixsage-9.2
Status: needs_reviewpositive_review

Thanks!

comment:10 Changed 2 years ago by Samuel Lelièvre

Description: modified (diff)
Reviewers: Samuel Lelièvre

comment:11 Changed 2 years ago by Vincent Pilaud

Thanks Samuel and Frédéric for the links and resolution of the ticket.

comment:12 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.2sage-9.3

comment:13 Changed 2 years ago by Volker Braun

Branch: u/chapoton/305454c3016a60af07b5bbb5cf0b1f3e161cfdb648895
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.