Opened 15 years ago

Closed 15 years ago

#3054 closed defect (fixed)

[with patch, positive review] copying a graph doesn't copy _pos or _boundary

Reported by: jason Owned by: rlm
Priority: major Milestone: sage-3.0.1
Component: graph theory Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This means that changing the position of nodes in the copy will affect the original.

Attachments (1)

trac-3054-graph-copy.patch​ (1.4 KB) - added by jason 15 years ago.

Download all attachments as: .zip

Change History (5)

Changed 15 years ago by jason

Attachment: trac-3054-graph-copy.patch​ added

comment:1 Changed 15 years ago by jason

Summary: copying a graph doesn't copy _pos or _boundary → [with patch, needs review] copying a graph doesn't copy _pos or _boundary

With #3054 and #3055 applied, doctests pass in the graphs/ directory.

comment:2 Changed 15 years ago by rlm

Summary: [with patch, needs review] copying a graph doesn't copy _pos or _boundary → [with patch, positive review pending tests] copying a graph doesn't copy _pos or _boundary

Have not run doctests, but I support this fix.

comment:3 Changed 15 years ago by mabshoff

Summary: [with patch, positive review pending tests] copying a graph doesn't copy _pos or _boundary → [with patch, positive review] copying a graph doesn't copy _pos or _boundary

#3054 and #3055 applied to my current merge tree doctest clean. So I am considering this a positive review.

Cheers,

Michael

comment:4 Changed 15 years ago by mabshoff

Resolution: → fixed
Status: new → closed

Merged in Sage 3.0.1.alpha1

Note: See TracTickets for help on using tickets.