Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#30538 closed enhancement (fixed)

some flake8 cleanup in manifolds

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.2
Component: manifolds Keywords:
Cc: egourgoulhon Merged in:
Authors: Frédéric Chapoton Reviewers: Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: dc768e4 (Commits, GitHub, GitLab) Commit: dc768e4bf97419b24b019a942448dc5c317532a2
Dependencies: Stopgaps:

Status badges

Description

mainly about E701 and E702 : one command per line

Change History (6)

comment:1 Changed 6 months ago by chapoton

  • Branch set to u/chapoton/30538
  • Cc egourgoulhon added
  • Commit set to dc768e4bf97419b24b019a942448dc5c317532a2

New commits:

​dc768e4flake8 details in manifolds/ (E701 and E702)

comment:2 Changed 6 months ago by egourgoulhon

Thanks for taking care of this. Is the ticket ready for review?

comment:3 Changed 6 months ago by chapoton

  • Status changed from new to needs_review

yes, I was just waiting for a patchbot, but this takes along time

comment:4 Changed 6 months ago by egourgoulhon

  • Reviewers set to Eric Gourgoulhon
  • Status changed from needs_review to positive_review

LGTM. The patchbot failures are not related to this ticket.

comment:5 Changed 6 months ago by vbraun

  • Branch changed from u/chapoton/30538 to dc768e4bf97419b24b019a942448dc5c317532a2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:6 Changed 6 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.2
Note: See TracTickets for help on using tickets.