Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#30538 closed enhancement (fixed)

some flake8 cleanup in manifolds

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-9.2
Component: manifolds Keywords:
Cc: Eric Gourgoulhon Merged in:
Authors: Frédéric Chapoton Reviewers: Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: dc768e4 (Commits, GitHub, GitLab) Commit: dc768e4bf97419b24b019a942448dc5c317532a2
Dependencies: Stopgaps:

Status badges

Description

mainly about E701 and E702 : one command per line

Change History (6)

comment:1 Changed 2 years ago by Frédéric Chapoton

Branch: → u/chapoton/30538
Cc: Eric Gourgoulhon added
Commit: → dc768e4bf97419b24b019a942448dc5c317532a2

New commits:

​dc768e4flake8 details in manifolds/ (E701 and E702)

comment:2 Changed 2 years ago by Eric Gourgoulhon

Thanks for taking care of this. Is the ticket ready for review?

comment:3 Changed 2 years ago by Frédéric Chapoton

Status: new → needs_review

yes, I was just waiting for a patchbot, but this takes along time

comment:4 Changed 2 years ago by Eric Gourgoulhon

Reviewers: → Eric Gourgoulhon
Status: needs_review → positive_review

LGTM. The patchbot failures are not related to this ticket.

comment:5 Changed 2 years ago by Volker Braun

Branch: u/chapoton/30538 → dc768e4bf97419b24b019a942448dc5c317532a2
Resolution: → fixed
Status: positive_review → closed

comment:6 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.3 → sage-9.2
Note: See TracTickets for help on using tickets.