Opened 15 months ago

Closed 15 months ago

#30535 closed defect (fixed)

conda-forge-macos-standard: sagelib build fails with linbox-related error

Reported by: mkoeppe Owned by:
Priority: blocker Milestone: sage-9.2
Component: build Keywords:
Cc: isuruf, saraedum, cpernet, dimpase, jhpalmieri Merged in:
Authors: Matthias Koeppe Reviewers: Isuru Fernando
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: a7b30f0 (Commits, GitHub, GitLab) Commit: a7b30f0da9590a19a66753b2445b16f20d00021f
Dependencies: Stopgaps:

Status badges

Description

conda-forge-macos-standard (​https://github.com/sagemath/sage/runs/1078909711): 

  [sagelib-9.2.beta12]   /Users/runner/work/sage/sage/.tox/local-conda-forge-macos-standard/local/include/linbox/algorithms/det-rational.h:96:39: error: no viable overloaded '='
  [sagelib-9.2.beta12]                   void detMul (const Integer& m) {mul = m;}
  [sagelib-9.2.beta12]                                                   ~~~ ^ ~
  [sagelib-9.2.beta12]   /Users/runner/work/sage/sage/.tox/local-conda-forge-macos-standard/conda/include/gmp++/gmp++_int.h:236:34: note: candidate function not viable: 'this' argument has type 'const LinBox::Integer' (aka 'const Givaro::Integer'), but method is not marked const
  [sagelib-9.2.beta12]           giv_all_inlined Integer& operator = (const Integer& n);
  [sagelib-9.2.beta12]                                    ^
  [sagelib-9.2.beta12]   build/cythonized/sage/matrix/matrix_integer_sparse.cpp:12289:35: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'long' [-Wsign-compare]
  [sagelib-9.2.beta12]     for (__pyx_t_12 = 0; __pyx_t_12 < __pyx_t_11; __pyx_t_12+=1) {
  [sagelib-9.2.beta12]                          ~~~~~~~~~~ ^ ~~~~~~~~~~
  [sagelib-9.2.beta12]   1 warning and 2 errors generated.
  [sagelib-9.2.beta12]   error: command 'x86_64-apple-darwin13.4.0-clang' failed with exit status 1

Regression from 9.1, which supported conda-forge-macos-standard.

Change History (8)

comment:1 Changed 15 months ago by mkoeppe

  • Cc cpernet dimpase added

Same as reported in ​https://github.com/linbox-team/givaro/pull/161 and solved in ​https://github.com/linbox-team/linbox/pull/256

comment:2 Changed 15 months ago by mkoeppe

  • Report Upstream changed from N/A to Fixed upstream, but not in a stable release.

comment:3 Changed 15 months ago by mkoeppe

  • Branch set to u/mkoeppe/conda_forge_macos_standard__sagelib_build_fails_with_linbox_related_error

comment:4 Changed 15 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to a7b30f0da9590a19a66753b2445b16f20d00021f
  • Status changed from new to needs_review

New commits:

​f363341build/pkgs/linbox: Add patch from linbox pr 256
​a7b30f0build/pkgs/linbox: Reduce patch from linbox pr 256 so it applies

comment:5 Changed 15 months ago by mkoeppe

  • Cc jhpalmieri added

comment:6 Changed 15 months ago by isuruf

  • Reviewers set to Isuru Fernando
  • Status changed from needs_review to positive_review

comment:7 Changed 15 months ago by mkoeppe

Thanks!

comment:8 Changed 15 months ago by vbraun

  • Branch changed from u/mkoeppe/conda_forge_macos_standard__sagelib_build_fails_with_linbox_related_error to a7b30f0da9590a19a66753b2445b16f20d00021f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.