Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#30533 closed enhancement (fixed)

Add quiet mode for bootstrap

Reported by: slelievre Owned by:
Priority: major Milestone: sage-9.2
Component: build: configure Keywords: quiet
Cc: mjo, mkoeppe, slelievre Merged in:
Authors: Michael Orlitzky Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 9c39bc8 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

This ticket is to add a -q flag to bootstrap so that it will print out less.

Change History (10)

comment:1 Changed 15 months ago by mjo

  • Authors set to Michael Orlitzky
  • Branch set to u/mjo/ticket/30533
  • Commit set to 8f91dbc90069cef514ffd87add26e5a7dc5077e7

Somebody want to come up with usage() strings for the other options? I'm not really sure what they're meant to do.


New commits:

f537959Trac #30533: add new -q (quiet) flag for the bootstrap process.
6547b33Trac #30533: hide automake (stderr) output from ./bootstrap -q.
8c2efbfTrac #30533: improve ./bootstrap usage() a bit.
8f91dbcTrac #30533: whitespace cleanup in ./bootstrap.

comment:2 Changed 15 months ago by slelievre

My understanding is:

  -d        download a pre-made `configure` script
  -D        download and ensure future invocations will download too
  -s        save the `configure` script
  -u <URL>  use <URL> as the download url for a pre-made `configure` script
  -?        print this help and exit with an error
Last edited 15 months ago by slelievre (previous) (diff)

comment:3 Changed 15 months ago by git

  • Commit changed from 8f91dbc90069cef514ffd87add26e5a7dc5077e7 to 59185e675b66be56ed3f303735f475390c9de6c5

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

33c5fccTrac #30533: improve ./bootstrap usage() a bit.
aa238d5Trac #30533: whitespace cleanup in ./bootstrap.
ab1cedaTrac #30533: rename bootstrap-download() to bootstrap_download().
63d539fTrac #30533: use /bin/sh to run the bootstrap script instead of bash.
3f4c45aTrac #30533: hide output from "./bootstrap -s" in quiet mode.
59185e6Trac #30533: hide info output from "./bootstrap -D" in quiet mode.

comment:4 Changed 15 months ago by git

  • Commit changed from 59185e675b66be56ed3f303735f475390c9de6c5 to 912af9bcf171da59824c0f4775932f72ddedc09a

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2d443aeTrac #30533: improve ./bootstrap usage() a bit.
c6ed563Trac #30533: whitespace cleanup in ./bootstrap.
31cb178Trac #30533: rename bootstrap-download() to bootstrap_download().
358ddc5Trac #30533: use /bin/sh to run the bootstrap script instead of bash.
de351f1Trac #30533: hide output from "./bootstrap -s" in quiet mode.
912af9bTrac #30533: hide info output from "./bootstrap -D" in quiet mode.

comment:5 Changed 15 months ago by git

  • Commit changed from 912af9bcf171da59824c0f4775932f72ddedc09a to 9c39bc89e19f05c2b4d29d8f339c33c880f33e61

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

171b947Trac #30533: improve ./bootstrap usage() a bit.
7dcb5a8Trac #30533: whitespace cleanup in ./bootstrap.
ab83893Trac #30533: rename bootstrap-download() to bootstrap_download().
2b4272dTrac #30533: use /bin/sh to run the bootstrap script instead of bash.
b85f4a1Trac #30533: hide output from "./bootstrap -s" in quiet mode.
9c39bc8Trac #30533: hide info output from "./bootstrap -D" in quiet mode.

comment:6 Changed 15 months ago by mjo

  • Status changed from new to needs_review

All good now, I hope. The output should be hidden from ./bootstrap -s -q and ./bootstrap -D -q now too.

comment:7 Changed 15 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

This is a nice improvement

comment:8 Changed 15 months ago by vbraun

  • Branch changed from u/mjo/ticket/30533 to 9c39bc89e19f05c2b4d29d8f339c33c880f33e61
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 15 months ago by mkoeppe

  • Commit 9c39bc89e19f05c2b4d29d8f339c33c880f33e61 deleted

Actually the change from bash to /bin/sh seems to have changed the set -e default, and bootstrap no longer works if src/bin/sage-env-config does not already exist.

comment:10 Changed 15 months ago by mkoeppe

Follow-up: #30664

Note: See TracTickets for help on using tickets.