#30532 closed enhancement (fixed)

sage.rings.ideal: Do not import sage.interfaces.singular at load time

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.2
Component: commutative algebra Keywords:
Cc: gh-mwageringel, tscrim Merged in:
Authors: Matthias Koeppe Reviewers: Travis Scrimshaw, Markus Wageringel
Report Upstream: N/A Work issues:
Branch: aabb620 (Commits, GitHub, GitLab) Commit: aabb6202fb4b5531ddcabaf4a17756eb89c33f7c
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

(split out from #29865)

Change History (7)

comment:1 Changed 15 months ago by mkoeppe

  • Branch set to u/mkoeppe/sage_rings_ideal__do_not_import_sage_interfaces_singular_at_load_time

comment:2 Changed 15 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc gh-mwageringel tscrim added
  • Commit set to 2d752412bdd22b0c3e0fb19b55ebfe3135d32641
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

2d75241sage.rings.ideal: Do not import sage.interfaces.singular at load time

comment:3 Changed 15 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

Good idea. Green bot => positive review.

comment:4 Changed 15 months ago by git

  • Commit changed from 2d752412bdd22b0c3e0fb19b55ebfe3135d32641 to aabb6202fb4b5531ddcabaf4a17756eb89c33f7c

Branch pushed to git repo; I updated commit sha1. New commits:

aabb620src/sage/rings/ideal.py: Fix a pycodestyle warning

comment:5 Changed 15 months ago by gh-mwageringel

  • Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Markus Wageringel
  • Status changed from needs_review to positive_review

Bot is green.

comment:6 Changed 15 months ago by mkoeppe

Thanks!

comment:7 Changed 15 months ago by vbraun

  • Branch changed from u/mkoeppe/sage_rings_ideal__do_not_import_sage_interfaces_singular_at_load_time to aabb6202fb4b5531ddcabaf4a17756eb89c33f7c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.