Opened 2 years ago
Closed 21 months ago
#30530 closed enhancement (fixed)
some flake8 cleanup in elliptic curve
Reported by:  chapoton  Owned by:  

Priority:  minor  Milestone:  sage9.3 
Component:  elliptic curves  Keywords:  
Cc:  cremona, tscrim  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  John Cremona 
Report Upstream:  N/A  Work issues:  
Branch:  98fc506 (Commits, GitHub, GitLab)  Commit:  98fc506cea2452d2b950c08db341a2358f5f1fb1 
Dependencies:  Stopgaps: 
Description (last modified by )
mainly about E701, E702 : one command per line
Change History (10)
comment:1 Changed 2 years ago by
 Branch set to u/chapoton/30530
 Commit set to c89962a4c7573917e639c374999e281be3f9f722
 Status changed from new to needs_review
comment:2 Changed 2 years ago by
 Commit changed from c89962a4c7573917e639c374999e281be3f9f722 to 98fc506cea2452d2b950c08db341a2358f5f1fb1
Branch pushed to git repo; I updated commit sha1. New commits:
98fc506  fix syntax error

comment:3 Changed 2 years ago by
 Description modified (diff)
comment:5 Changed 2 years ago by
 Status changed from needs_review to positive_review
It is hardly necessary for a human to review whitespace/stylistic changes if we delegate these to an automatic process. I did see a few changes which are not just w/s. And I did not know that one could write something like "if K is not QQ" instead of "if not K is QQ"!
comment:6 followup: ↓ 7 Changed 2 years ago by
Thanks John.
This was done by hand, so the review is needed, but very boring indeed.
Indeed most of the changes are trivial. The idea is to later check this directly before the new code enter sage. But we have to cleanup all the existing code also.
Using x is not y
and x not in Z
seems to be the recommended way now.
comment:7 in reply to: ↑ 6 Changed 2 years ago by
Replying to chapoton:
Thanks John.
This was done by hand, so the review is needed, but very boring indeed.
Not as boring  and a lot quicker!  than making the edits. I appreciate that (especially as a good fraction of the changes were in lines I wrote).
Indeed most of the changes are trivial. The idea is to later check this directly before the new code enter sage. But we have to cleanup all the existing code also.
Using
x is not y
andx not in Z
seems to be the recommended way now.
comment:8 Changed 2 years ago by
 Reviewers set to John Cremona
comment:9 Changed 22 months ago by
 Milestone changed from sage9.2 to sage9.3
comment:10 Changed 21 months ago by
 Branch changed from u/chapoton/30530 to 98fc506cea2452d2b950c08db341a2358f5f1fb1
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
some cleaning using flake8 in elliptic curves folder