Opened 2 years ago
Closed 21 months ago
#30529 closed enhancement (fixed)
Use reference instead of pointer to simplify code
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-9.3 |
Component: | geometry | Keywords: | combinatorial polyhedron, face iterator |
Cc: | tscrim | Merged in: | |
Authors: | Jonathan Kliem | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 5b21614 (Commits, GitHub, GitLab) | Commit: | 5b216140cd930e824ba5629e15475c443a9d7d6f |
Dependencies: | #30524 | Stopgaps: |
Description
By using a reference to a structure the code is much better to read.
Instead of structptr[0].newfaces[structptr[0].current_dimension-1]
we now have structure.newfaces[structure.current_dimension-1]
.
Change History (8)
comment:1 Changed 2 years ago by
- Status changed from new to needs_review
comment:2 Changed 2 years ago by
- Keywords combinatorial polyhedron face iterator added
- Milestone changed from sage-9.2 to sage-9.3
comment:3 follow-up: ↓ 6 Changed 2 years ago by
- Reviewers set to Travis Scrimshaw
comment:4 Changed 2 years ago by
- Commit changed from df7d31c87de15cc6194fd9577d6b9f5bcf4b0ac8 to 4f86f02892065a9c7e65eccc3a1214685aeb711a
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
f3e2ddc | prepare slightly modified algorithm for simple/simplicial polytopes
|
edad681 | typo
|
5939b5d | faster algorithm for simple/simplicial polytopes
|
f997cec | small fixes
|
63b7bd6 | improvements in documentation
|
f2edc3d | get rid of maybe_newfaces
|
6dfbe81 | get rid of compute_dimension_loop
|
f2dd072 | do not expose the coatoms
|
fc8124a | fix mistake
|
4f86f02 | use reference so simplify code
|
comment:5 Changed 2 years ago by
- Commit changed from 4f86f02892065a9c7e65eccc3a1214685aeb711a to 5b216140cd930e824ba5629e15475c443a9d7d6f
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
5b21614 | use reference so simplify code
|
comment:6 in reply to: ↑ 3 Changed 2 years ago by
Replying to tscrim:
If you could just rebase the branch to clean up the history a bit, then you can set a positive review.
Thank you. This ticket is only one commit. Now you can see it.
comment:7 Changed 2 years ago by
- Status changed from needs_review to positive_review
comment:8 Changed 21 months ago by
- Branch changed from u/gh-kliem/simplify_face_struct_pointer to 5b216140cd930e824ba5629e15475c443a9d7d6f
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
If you could just rebase the branch to clean up the history a bit, then you can set a positive review.