Opened 2 years ago

Closed 23 months ago

#30526 closed defect (fixed)

Irrelevant Example for _polynomial_list at FP_template.pxi

Reported by: gh-n-vi Owned by:
Priority: major Milestone: sage-9.2
Component: padics Keywords: doctest
Cc: Merged in:
Authors: Noa Viner Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 4cbbefd (Commits, GitHub, GitLab) Commit: 4cbbefde83ee8b5ca6b948c6af0e893bd60dd33d
Dependencies: Stopgaps:

Status badges

Description

In the implementation of _polynomial_list which is written in FP_template.pxi, the given example is irrelevant: it has accidentally been copied from CR_template.pxi.

Change History (5)

comment:1 Changed 2 years ago by gh-n-vi

  • Branch set to u/gh-n-vi/irrelevant_example_for__polynomial_list_at_fp_template_pxi

comment:2 Changed 2 years ago by gh-n-vi

  • Authors set to Noa Viner
  • Commit set to 4cbbefde83ee8b5ca6b948c6af0e893bd60dd33d
  • Status changed from new to needs_review

New commits:

​4cbbefdReplacing with a relevant example.

comment:3 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 2 years ago by gh-n-vi

Thank you!

comment:5 Changed 23 months ago by vbraun

  • Branch changed from u/gh-n-vi/irrelevant_example_for__polynomial_list_at_fp_template_pxi to 4cbbefde83ee8b5ca6b948c6af0e893bd60dd33d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.