Opened 2 years ago
Closed 2 years ago
#30510 closed enhancement (fixed)
Speed up method subgraph
Reported by: | dcoudert | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | graph theory | Keywords: | |
Cc: | tscrim | Merged in: | |
Authors: | David Coudert | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 0345f0b (Commits, GitHub, GitLab) | Commit: | 0345f0b09ba350c80a98e822f028af7077c66ab2 |
Dependencies: | Stopgaps: |
Description (last modified by )
We slightly speed up methods _subgraph_by_adding
and _subgraph_by_deleting
by checking if a vertex belongs to a graph or a set instead of checking if it belongs to a list of vertices. This benefits all methods using subgraph
.
Change History (5)
comment:1 Changed 2 years ago by
Branch: | → public/graphs/30510_subgraph |
---|---|
Commit: | → 3eefdf7a1dbc3537a1103c7dcdadc98db3d95040 |
Description: | modified (diff) |
Status: | new → needs_review |
comment:2 Changed 2 years ago by
Commit: | 3eefdf7a1dbc3537a1103c7dcdadc98db3d95040 → 0345f0b09ba350c80a98e822f028af7077c66ab2 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
0345f0b | trac #30510: check only if vertices is not None
|
comment:4 Changed 2 years ago by
Reviewers: | → Travis Scrimshaw |
---|---|
Status: | needs_review → positive_review |
LGTM.
comment:5 Changed 2 years ago by
Branch: | public/graphs/30510_subgraph → 0345f0b09ba350c80a98e822f028af7077c66ab2 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
trac #30510: improve method subgraph