Opened 14 years ago

Closed 14 years ago

#3050 closed enhancement (fixed)

[with patch; positive review] notebook -- add a "remember me" checkbox to the login page.

Reported by: TimothyClemans Owned by: TimothyClemans
Priority: major Milestone: sage-3.0.2
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by was)

Many webpages have a little "remember me" checkbox to determine whether you have to enter login credentials every time you visit a web page. Possibly implement something similar in Sage.

Attachments (2)

extcode-3050.patch (877 bytes) - added by TimothyClemans 14 years ago.
trac_3050-revised-sage-3050.patch (2.3 KB) - added by TimothyClemans 14 years ago.
new and includes sage-3050.patch and sage-3050_2.patch

Download all attachments as: .zip

Change History (16)

comment:1 Changed 14 years ago by was

  • Description modified (diff)
  • Summary changed from notebook -- add "remember me" checkbox to notebook -- add a "remember me" checkbox to the login page.

The Knoboo people have this feature. Timothy attached a patch that is relevant to their implementation, which might be of some use to whoever implements this for sage.

comment:2 Changed 14 years ago by TimothyClemans

I want to make it clear that this functionality is not in Knoboo currently. From Alex Clemesha, "We will get this into knoboo as soon as the "settings" functionality starts to settle into knoboo, because, (as you would probably agree), this only thing missing with the patch would be a way for the Admin user to set the "expires time" (instead of hard-coded)."

Changed 14 years ago by TimothyClemans

comment:3 Changed 14 years ago by TimothyClemans

  • Summary changed from notebook -- add a "remember me" checkbox to the login page. to [with patch; needs review] notebook -- add a "remember me" checkbox to the login page.

Fixes #3155 also.

comment:4 Changed 14 years ago by TimothyClemans

Warning: Depends on #3213

comment:5 Changed 14 years ago by was

REVIEW:

  1. It would be nice if you added a comment about what is going on in the modifications to twist.py.
  1. I don't actually understand how to test that this patch is actually doing something! Could you give me simple step-by-step instructions to test out a situation where the behavior of something is different whether or not remember me is checked? Does this feature only do anything when there are multiple accounts? I tried what I thought was the obvious test, and it seems like Remember Me just doesn't work. We can figure this out at the cafe today.

comment:6 Changed 14 years ago by was

  • Summary changed from [with patch; needs review] notebook -- add a "remember me" checkbox to the login page. to [with patch; positive review] notebook -- add a "remember me" checkbox to the login page.

comment:7 Changed 14 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged all three patches in Sage 3.0.2.alpha1

comment:8 Changed 14 years ago by was

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hi,

I was just using Sage on my computer with this patch applied and having a lot of problems if I open and close my browser. I get into a state where I absolutely can't login, etc.

I.e., this patch is definitely not ready for prime time. It will break the notebook for a lot of people in confusing ways.

We'll get it fixed though.

comment:9 Changed 14 years ago by mabshoff

  • Summary changed from [with patch; positive review] notebook -- add a "remember me" checkbox to the login page. to [with patch; reverted] notebook -- add a "remember me" checkbox to the login page.

Changed 14 years ago by TimothyClemans

new and includes sage-3050.patch and sage-3050_2.patch

comment:10 Changed 14 years ago by TimothyClemans

  • Summary changed from [with patch; reverted] notebook -- add a "remember me" checkbox to the login page. to [with patch; needs review] notebook -- add a "remember me" checkbox to the login page.

I changed the cookie name to the static name "nb_session" in both the render for UserToplevel? and in the function get_our_cookie in guard.py. I don't know if doing this fixes the problem.

comment:11 Changed 14 years ago by was

  • Summary changed from [with patch; needs review] notebook -- add a "remember me" checkbox to the login page. to [with patch; positive review] notebook -- add a "remember me" checkbox to the login page.

The new patch works.

comment:12 Changed 14 years ago by was

  • Summary changed from [with patch; positive review] notebook -- add a "remember me" checkbox to the login page. to [with patch; negative review] notebook -- add a "remember me" checkbox to the login page.

The new patch still causes problems, where notebooks just "don't work". This is very serious and would cause mass problems by users.

comment:13 Changed 14 years ago by was

  • Summary changed from [with patch; negative review] notebook -- add a "remember me" checkbox to the login page. to [with patch; positive review] notebook -- add a "remember me" checkbox to the login page.

Wait, I spoke too soon. I was confused by another separate problem.

comment:14 Changed 14 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from reopened to closed

Merged extcode-3050.patch and trac_3050-revised-sage-3050.patch in Sage 3.0.2.alpha1

Note: See TracTickets for help on using tickets.