Opened 2 years ago
Closed 2 years ago
#30487 closed enhancement (fixed)
GH Actions: Test also with Xcode 12 beta
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | porting | Keywords: | |
Cc: | jhpalmieri, gh-kliem | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Jonathan Kliem |
Report Upstream: | N/A | Work issues: | |
Branch: | bec68e2 (Commits, GitHub, GitLab) | Commit: | bec68e23f0c5d384ba9db4e4cafa820a2cfeef68 |
Dependencies: | Stopgaps: |
Description (last modified by )
in preparation for macOS 11 - see https://groups.google.com/d/msg/sage-support/ZLgu-1pi6nc/LH2Mma_uAgAJ
The workflow can be seen at:
- https://github.com/mkoeppe/sage/runs/1059961873 (confirming previously reported package build errors)
- https://github.com/mkoeppe/sage/runs/1059961897 (revealing that some homebrew packages fail in from-source builds)
Part of meta-ticket #30494: Support Xcode 12, macOS 11 Big Sur
References:
https://github.com/marketplace/actions/setup-xcode-version
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#xcode
Change History (14)
comment:1 Changed 2 years ago by
- Description modified (diff)
comment:2 Changed 2 years ago by
- Reviewers set to github.com/mkoeppe/sage/actions/runs/235534837
comment:3 Changed 2 years ago by
- Reviewers changed from github.com/mkoeppe/sage/actions/runs/235534837 to github.com/mkoeppe/sage/actions/runs/235542644
comment:4 Changed 2 years ago by
- Description modified (diff)
comment:5 Changed 2 years ago by
- Branch set to u/mkoeppe/gh_actions__test_also_with_xcode_12_beta
comment:6 Changed 2 years ago by
- Cc gh-kliem added
- Commit set to bec68e23f0c5d384ba9db4e4cafa820a2cfeef68
- Status changed from new to needs_review
comment:7 follow-up: ↓ 12 Changed 2 years ago by
Isn't the location of that thing /Applications/Xcode_12_beta.app
?
It looks to me that you select /Applications/Xcode_12.app
. Is this guaranteed to work?
comment:8 Changed 2 years ago by
On my machine, it's /Applications/Xcode-beta.app
.
comment:9 follow-up: ↓ 11 Changed 2 years ago by
This contradicts https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#xcode, but I guess that is a "user" created page and maybe it is not up to date.
comment:10 follow-up: ↓ 13 Changed 2 years ago by
- Reviewers changed from github.com/mkoeppe/sage/actions/runs/235542644 to Jonathan Kliem
- Status changed from needs_review to positive_review
LGTM.
comment:11 in reply to: ↑ 9 Changed 2 years ago by
Replying to gh-kliem:
This contradicts https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#xcode, but I guess that is a "user" created page and maybe it is not up to date.
Yes, this page is outdated.
comment:12 in reply to: ↑ 7 Changed 2 years ago by
Replying to gh-kliem:
It looks to me that you select
/Applications/Xcode_12.app
. Is this guaranteed to work?
This is the path that currently works.
comment:13 in reply to: ↑ 10 Changed 2 years ago by
comment:14 Changed 2 years ago by
- Branch changed from u/mkoeppe/gh_actions__test_also_with_xcode_12_beta to bec68e23f0c5d384ba9db4e4cafa820a2cfeef68
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
.github/workflows/tox.yml: Test with XCode 12 beta