Opened 17 months ago
Closed 11 months ago
#30482 closed task (fixed)
Remove src/sage/symbolic/todo.txt
Reported by: | slelievre | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.3 |
Component: | symbolics | Keywords: | todo |
Cc: | slelievre | Merged in: | |
Authors: | Dave Morris | Reviewers: | Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | cf120a8 (Commits, GitHub, GitLab) | Commit: | cf120a8ed7856f45d0637c083240398cc17a15f0 |
Dependencies: | Stopgaps: |
Description
Turn any remaining items of the todo list in that file into tickets.
Change History (10)
comment:1 Changed 15 months ago by
- Milestone changed from sage-9.2 to sage-9.3
comment:2 Changed 12 months ago by
comment:3 Changed 12 months ago by
Here is the one issue that is missing from the above list:
* print degree order: Now, sage: x^2 + x^4 + x^3 x^2 + x^3 + x^4 sage: a^3*x^10 + x^12 - a^15 x^12 + a^3*x^10 - a^15 So it is printing from lowest to highest degree, like mathematica (or power series), but unlike the standard sage convention (or maple, singular, MATH, etc.): sage: R.<a,x> = QQ[] sage: a^3*x^10 + x^12 - a^15 -a^15 + a^3*x^10 + x^12 sage: singular(a^3*x^10 + x^12 - a^15) -a^15+a^3*x^10+x^12
I did not include it because this issue is also done, even though it was not marked that way in the file. With 9.3b6, we have:
sage: var("a"); sage: x^2 + x^4 + x^3 x^4 + x^3 + x^2 sage: a^3*x^10 + x^12 - a^15 -a^15 + a^3*x^10 + x^12
The terms go from highest degree to lowest, as they should.
comment:4 Changed 12 months ago by
- Branch set to public/30482
comment:5 Changed 12 months ago by
- Commit set to cf120a8ed7856f45d0637c083240398cc17a15f0
- Status changed from new to needs_review
comment:6 Changed 11 months ago by
comment:7 Changed 11 months ago by
The commit message has a typo ("emove" for "remove"); amend it and force push?
comment:8 Changed 11 months ago by
I'm not confident enough with git to try a force push. It's fine with me if you want to do that (the branch is public), or I could push a new branch with the correct commit message.
comment:9 Changed 11 months ago by
- Reviewers set to Matthias Koeppe
- Status changed from needs_review to positive_review
comment:10 Changed 11 months ago by
- Branch changed from public/30482 to cf120a8ed7856f45d0637c083240398cc17a15f0
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Here are (all but one of) the issues that are not marked "done" in the file. I am numbering them, for ease of reference.
If there is no discussion, I will open a single ticket that lists all 5 of these.