Opened 2 years ago

Closed 21 months ago

#30482 closed task (fixed)

Remove src/sage/symbolic/todo.txt

Reported by: Samuel Lelièvre Owned by:
Priority: major Milestone: sage-9.3
Component: symbolics Keywords: todo
Cc: Samuel Lelièvre Merged in:
Authors: Dave Morris Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: cf120a8 (Commits, GitHub, GitLab) Commit: cf120a8ed7856f45d0637c083240398cc17a15f0
Dependencies: Stopgaps:

Status badges


Turn any remaining items of the todo list in that file into tickets.

Change History (10)

comment:1 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.2sage-9.3

comment:2 Changed 22 months ago by Dave Morris

Here are (all but one of) the issues that are not marked "done" in the file. I am numbering them, for ease of reference.

Todo 1: genuine coercions to real field, etc.
Todo 2: optimize is_even in numeric.cpp
Todo 3: Support pickle via the "archive" print mode.
Todo 4: need to be able to do this (from ginsh):
> collect_common_factors(x/(x^2 + x));
Todo 5: Maybe change Sage's GiNaC to make a call to a Cython gcd function, then use
Singular, since Singular's gcd over QQ is much better than GiNaC's, I think,
and GiNaC *only* does GCD over QQ.  Actually, just make everything in normal.cpp
be implemented via Singular, probably...

If there is no discussion, I will open a single ticket that lists all 5 of these.

Last edited 22 months ago by Dave Morris (previous) (diff)

comment:3 Changed 22 months ago by Dave Morris

Here is the one issue that is missing from the above list:

* print degree order:
sage: x^2 + x^4 + x^3
x^2 + x^3 + x^4
sage: a^3*x^10 + x^12 - a^15
x^12 + a^3*x^10 - a^15

So it is printing from lowest to highest degree, like mathematica (or power series),
but unlike the standard sage convention (or maple, singular, MATH, etc.):
sage: R.<a,x> = QQ[]
sage: a^3*x^10 + x^12 - a^15
-a^15 + a^3*x^10 + x^12
sage: singular(a^3*x^10 + x^12 - a^15)

I did not include it because this issue is also done, even though it was not marked that way in the file. With 9.3b6, we have:

sage: var("a");                                                                        
sage: x^2 + x^4 + x^3                                                                  
x^4 + x^3 + x^2
sage: a^3*x^10 + x^12 - a^15                                                           
-a^15 + a^3*x^10 + x^12

The terms go from highest degree to lowest, as they should.

comment:4 Changed 22 months ago by Dave Morris

Branch: public/30482

comment:5 Changed 22 months ago by Dave Morris

Authors: Dave Morris
Commit: cf120a8ed7856f45d0637c083240398cc17a15f0
Status: newneeds_review

PR removes the todo file.

New commits:

cf120a8trac 30482 emove todo.txt

comment:6 Changed 22 months ago by Dave Morris

The tasks listed in comment:2 are now in #31393.

comment:7 Changed 22 months ago by Samuel Lelièvre

The commit message has a typo ("emove" for "remove"); amend it and force push?

comment:8 Changed 22 months ago by Dave Morris

I'm not confident enough with git to try a force push. It's fine with me if you want to do that (the branch is public), or I could push a new branch with the correct commit message.

comment:9 Changed 22 months ago by Matthias Köppe

Reviewers: Matthias Koeppe
Status: needs_reviewpositive_review

comment:10 Changed 21 months ago by Volker Braun

Branch: public/30482cf120a8ed7856f45d0637c083240398cc17a15f0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.