Opened 6 months ago

Closed 6 months ago

#30470 closed enhancement (fixed)

Make spanning_trees an iterator

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-9.2
Component: graph theory Keywords:
Cc: tmonteil Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: c82008c (Commits, GitHub, GitLab) Commit: c82008c0549fbd49e174af14eeb064829f390d8c
Dependencies: Stopgaps:

Status badges

Description (last modified by dcoudert)

The number of spanning trees can be huge, so it's much better to use an iterator. We also move the method from graph.py to spanning_tree.pyx.

Change History (9)

comment:1 Changed 6 months ago by dcoudert

  • Branch set to public/graphs/30470_spanning_trees
  • Commit set to e39c81d16589368a173cf1c257c3f5d6df8e059b
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​e39c81dtrac #30470: make spanning_trees an iterator

comment:2 Changed 6 months ago by chapoton 

        from sage.graphs.connectivity import spanning trees
                                                         ^
    SyntaxError: invalid syntax

comment:3 Changed 6 months ago by git

  • Commit changed from e39c81d16589368a173cf1c257c3f5d6df8e059b to fdfea6dc7e9525a24ac439a068ca4908dc18cc1f

Branch pushed to git repo; I updated commit sha1. New commits:

​fdfea6dtrac #30470: fix syntax error

comment:4 Changed 6 months ago by dcoudert

Oups... should be better now.

comment:5 Changed 6 months ago by chapoton

now with 

ImportError: cannot import name 'spanning_trees' from 'sage.graphs.connectivity'

comment:6 Changed 6 months ago by git

  • Commit changed from fdfea6dc7e9525a24ac439a068ca4908dc18cc1f to c82008c0549fbd49e174af14eeb064829f390d8c

Branch pushed to git repo; I updated commit sha1. New commits:

​c82008ctrac #30470: fix doctests

comment:7 Changed 6 months ago by dcoudert

sorry for that. Need more coffee...

comment:8 Changed 6 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, ça roule

comment:9 Changed 6 months ago by vbraun

  • Branch changed from public/graphs/30470_spanning_trees to c82008c0549fbd49e174af14eeb064829f390d8c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.