Opened 7 months ago

Last modified 2 months ago

#30469 needs_work enhancement

Implement `as_polyhedron` for combinatorial faces of polyhedra

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.4
Component: geometry Keywords: polyhedral face, face figure, combinatorial polyhedron
Cc: Merged in:
Authors: Jonathan Kliem Reviewers:
Report Upstream: N/A Work issues:
Branch: u/gh-kliem/combinatorial_face_as_polyhedron (Commits, GitHub, GitLab) Commit: 6bc5e6728726530180a1fefa0c73e7f8d59e78a3
Dependencies: #30440, #30458 Stopgaps:

Status badges

Description (last modified by gh-kliem)

We implement a method that obtains a combinatorial face or the quotient.

This is much faster than as_polyhedron from polyhedral face and could be used to obtain a polyhedral face geometrically with precomputed double description.

Change History (8)

comment:1 Changed 7 months ago by git

  • Commit set to 4c18c3d106fc9d66ab7e4c3959f3e1a03f7812df

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

b35a670document pyramid method in `ListOfFaces`
afb046ctemporary commit
20a39b6outsource inclusion maximal
b672fcaremoved redundant function
a7b4f0aMerge branch 'u/gh-kliem/outsource_inclusion_maximal' of git://trac.sagemath.org/sage into u/gh-kliem/combinatorial_face_as_polyhedron
1f558dbtemporary commit
e12e0c5add test for trailing bits
57ad251remove unused things
281450edocumentation
4c18c3dsafe some time by random only some of the tests

comment:2 Changed 7 months ago by gh-kliem

  • Status changed from new to needs_review

comment:3 Changed 7 months ago by gh-kliem

  • Description modified (diff)
  • Status changed from needs_review to needs_work

comment:4 Changed 7 months ago by git

  • Commit changed from 4c18c3d106fc9d66ab7e4c3959f3e1a03f7812df to 6bc5e6728726530180a1fefa0c73e7f8d59e78a3

Branch pushed to git repo; I updated commit sha1. New commits:

6bc5e67use correct terminology

comment:5 Changed 7 months ago by gh-kliem

  • Status changed from needs_work to needs_review

comment:6 Changed 7 months ago by gh-kliem

  • Status changed from needs_review to needs_work

I want to redesign some of the setup before making everything more complicated.

More precisely, creating strucutures face_struct and faces_list_struct that take care of the details. Then this overly long argument list of get_next_level will just reduce to three arguments or so. This would also make future changes easier including the transition to bitsets.pxi.

comment:7 Changed 6 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:8 Changed 2 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

Note: See TracTickets for help on using tickets.