Opened 8 months ago
Closed 3 months ago
#30445 closed enhancement (fixed)
Merge duplications in edges, ridges and f-vector of combinatorial polyhedron
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.3 |
Component: | geometry | Keywords: | code duplication, combinatorial polyhedron |
Cc: | jipilab, gh-LaisRast, tscrim | Merged in: | |
Authors: | Jonathan Kliem | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 62b3d9f (Commits, GitHub, GitLab) | Commit: | 62b3d9f0eaf22fc9102f990f4c7f3754c1282f79 |
Dependencies: | #30443 | Stopgaps: |
Description
We merge some duplications of obtaining edges, ridges and f-vector.
There was an entire copy of getting edges/ridges that also obtained the f-vector. But it is much simpler doing this directly in the f-vector code.
Also getting the edges/ridges is almost the same thing. We can let the FaceIterator
worry about the details.
Change History (7)
comment:1 Changed 8 months ago by
- Status changed from new to needs_review
comment:2 Changed 6 months ago by
- Milestone changed from sage-9.2 to sage-9.3
comment:3 Changed 3 months ago by
- Cc jipilab gh-LaisRast tscrim added
comment:4 Changed 3 months ago by
- Reviewers set to Travis Scrimshaw
comment:5 Changed 3 months ago by
- Commit changed from 8814532248adab90b73c4335bcaf37848622a28e to 62b3d9f0eaf22fc9102f990f4c7f3754c1282f79
comment:7 Changed 3 months ago by
- Branch changed from u/gh-kliem/merge_edges_ridges_f_vector to 62b3d9f0eaf22fc9102f990f4c7f3754c1282f79
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Some minor formatting things (which you can either change or ignore and then set this to a positive review):