Opened 2 years ago

Closed 2 years ago

#30442 closed enhancement (fixed)

Implement general table art for tableau-like objects

Reported by: Travis Scrimshaw Owned by:
Priority: major Milestone: sage-9.2
Component: user interface Keywords: ascii unicode art
Cc: Sage Combinat CC user, Frédéric Chapoton, Nicolas M. Thiéry, Andrew Mathas, Ben Salisbury, Samuel Lelièvre, zerline Merged in:
Authors: Travis Scrimshaw Reviewers: Ben Salisbury, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 7388b34 (Commits, GitHub, GitLab) Commit: 7388b342ce5d6cae82f9ef2e70ea31d238cf453f
Dependencies: Stopgaps:

Status badges

Description

Tableaux have nice unicode art, but skew tableaux do not. This makes the ascii_art_table method of Tableau into a general purpose method for printing tables.

Change History (11)

comment:1 Changed 2 years ago by Travis Scrimshaw

Branch: public/combinat/more_unicode_art-30442
Cc: Ben Salisbury added
Commit: debbc417e416cfddce1f8b43a85758c9ca0b9394
Status: newneeds_review

Much prettier now IMO.


New commits:

debbc41Adding more robust ascii and unicode table art for tableau-like objects.

comment:2 Changed 2 years ago by Samuel Lelièvre

Cc: Samuel Lelièvre zerline added

comment:3 Changed 2 years ago by Ben Salisbury

Reviewers: Ben Salisbury
Status: needs_reviewpositive_review

Looks good to me. All tests passed.

comment:4 Changed 2 years ago by Volker Braun

Status: positive_reviewneeds_work

PDF docs don't build

comment:5 Changed 2 years ago by git

Commit: debbc417e416cfddce1f8b43a85758c9ca0b9394ef7c5eb0f9e285f2430145a8e2b0be984a583b1d

Branch pushed to git repo; I updated commit sha1. New commits:

ef7c5ebFixing pdf docbuild with the usual unicode expansion.

comment:6 Changed 2 years ago by Travis Scrimshaw

Status: needs_workneeds_review

This should fix it.

comment:7 Changed 2 years ago by Frédéric Chapoton

patchbot also complains about missing first lines for the encoding declarations, but I am not sure at all if this is pertinent still

comment:8 Changed 2 years ago by git

Commit: ef7c5eb0f9e285f2430145a8e2b0be984a583b1d7388b342ce5d6cae82f9ef2e70ea31d238cf453f

Branch pushed to git repo; I updated commit sha1. New commits:

7388b34Added "# -*- coding: utf-8 -*-" to top of files.

comment:9 in reply to:  7 Changed 2 years ago by Travis Scrimshaw

Replying to chapoton:

patchbot also complains about missing first lines for the encoding declarations, but I am not sure at all if this is pertinent still

IMO, it is safer just to add them. Done.

comment:10 Changed 2 years ago by Frédéric Chapoton

Reviewers: Ben SalisburyBen Salisbury, Frédéric Chapoton
Status: needs_reviewpositive_review

ok, good improvement, let's get that in

comment:11 Changed 2 years ago by Volker Braun

Branch: public/combinat/more_unicode_art-304427388b342ce5d6cae82f9ef2e70ea31d238cf453f
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.