Opened 13 months ago

Closed 9 months ago

Last modified 9 months ago

#30441 closed enhancement (fixed)

Graphs: added near polygons distance-regular graphs

Reported by: gh-Ivo-Maffei Owned by:
Priority: major Milestone: sage-9.3
Component: graph theory Keywords:
Cc: Merged in:
Authors: Ivo Maffei Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: e615813 (Commits, GitHub, GitLab) Commit:
Dependencies: #30414, #30439 Stopgaps:

Status badges

Description

Add functions to let graphs.distance_regular_graph construct near polygon graphs.

Change History (12)

comment:1 Changed 13 months ago by gh-Ivo-Maffei

  • Branch set to public/graphs/30414
  • Commit set to c64c5ecb4cd1526d234d6daffd5ab14f49c21921
  • Status changed from new to needs_review

Last 10 new commits:

​ed501d3fix another bug
​b94eb15added antipodal and folded graph methods; most docstrings done
​804c4b1fixed bug; finished docstrings/doctests
​20a2b68Merge branch 30394 into drg pseudo partition
​4b12c23added doctests; expanded folded graph to check antipodal; sketch antipodal implementations
​bd6466fremoved attepmts to antipodal_graph
​b549b0badded placeholder antipodal_graph method; #30405 should change it
​f1f9aa4fix docstring
​2ddc579Merge branch 30394 into pseudo partition
​c64c5ecadded psuedo partition graphs

comment:2 Changed 13 months ago by gh-Ivo-Maffei

  • Status changed from needs_review to needs_work

Wait for all dependencies to be sorted out

comment:3 Changed 12 months ago by git

  • Commit changed from c64c5ecb4cd1526d234d6daffd5ab14f49c21921 to 5590e3ea456e62cfb1ea83e309ed16be4ead409d

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

​898fbeeadded positions to HalfCube
​d9c9149Merge branch 't/30509' into t/30337
​3449361Merge branch 9.2.beta12 into t/30337
​b99474bMerge branch 't/30337' into t/30343
​7d17b7dremoved blank lines
​717cf19Merge branch 't/30343' into t/30356
​63c88c0fix bug; avoid long computations on import
​0cfe6ecMerge branch 't/30356' into t/30386
​a40aba1Merge branch 't/30386' into t/30414
​5590e3efix typo

comment:4 Changed 12 months ago by dimpase

what is the status here?

comment:5 Changed 12 months ago by gh-Ivo-Maffei

There's something wrong with the branch. I'm fixing it

comment:6 Changed 12 months ago by gh-Ivo-Maffei

  • Branch changed from public/graphs/30414 to public/graphs/30441
  • Commit changed from 5590e3ea456e62cfb1ea83e309ed16be4ead409d to 38b4496be3481881f2ca1ca903a7c3ccb9611690
  • Status changed from needs_work to needs_review

Should be fixed now

Last 10 new commits:

​039c92eadded doctest to general function
​2e8fbf5fix doctests
​dde9d1afix some long time that are too long
​e59515dMerge branch '30312' into near polygons
​cd075c7change long time to not tested
​5092924Merge branch 't/30394' into t/30441
​f6d5cc0Merge branch 't/30414' into t/30441
​13d9c5badded long time flag
​deeb6f0Merge branch 't/30414' into t/30441
​38b4496fixed typos

comment:7 Changed 12 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:8 Changed 11 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:9 Changed 10 months ago by dimpase

  • Status changed from positive_review to needs_work

needs merge with #30414

comment:10 Changed 10 months ago by dimpase

  • Branch changed from public/graphs/30441 to u/dimpase/graphs/30441
  • Commit changed from 38b4496be3481881f2ca1ca903a7c3ccb9611690 to e61581309d3be3585499660539dc27c6578b3095
  • Status changed from needs_work to positive_review

Last 10 new commits:

​54499c7sketch general function with conditionals for drg module
​c5f0f3dfixed most sporadic graphs; added some docstring; added method to graphs
​f675f2ccompleted sporadic database; added more docstrings; added basic checks
​e4b1d59fixed docstring and doctests
​9aa7d07fixed existence checks without drg module
​4bba926added doctests to _integersection_array_from_graph
​0a9a194fix bug; avoid long computations on import - typo fixed
​f9bb39aMerge branch 'public/graphs/30356' into public/graphs/30386
​bbb799fMerge branch 'public/graphs/30386' into public/graphs/30414
​e615813Merge branch 'public/graphs/30414' into public/graphs/30441

comment:11 Changed 9 months ago by vbraun

  • Branch changed from u/dimpase/graphs/30441 to e61581309d3be3585499660539dc27c6578b3095
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:12 Changed 9 months ago by slelievre

  • Commit e61581309d3be3585499660539dc27c6578b3095 deleted

In a follow-up ticket, maybe sort alphabetically?

Or add brief comment on merits of chosen enumeration order? 

 cdef enum ClassicalParametersGraph:
     NonExisting = 0,
-    Johnson,
-    Hamming,
-    HalvedCube,
-    UnitaryDualPolar,
-    HermitianForms,
-    GeneralisedHexagon,
-    Grassmann,
-    OrthogonalDualPolar1,
-    SymplecticDualPolar,
-    OrthogonalDualPolar2,
-    UnitaryDualPolar1,
-    UnitaryDualPolar2,
-    Ustimenko,
-    BilinearForms,
-    AlternatingForms,
-    LieE77,
-    AffineE6
+    AffineE6,
+    AlternatingForms,
+    BilinearForms,
+    GeneralisedHexagon,
+    Grassmann,
+    HalvedCube,
+    Hamming,
+    HermitianForms,
+    Johnson,
+    LieE77,
+    OrthogonalDualPolar1,
+    OrthogonalDualPolar2,
+    SymplecticDualPolar,
+    UnitaryDualPolar,
+    UnitaryDualPolar1,
+    UnitaryDualPolar2,
+    Ustimenko
Note: See TracTickets for help on using tickets.