Opened 8 months ago

Closed 7 months ago

#30440 closed enhancement (fixed)

Pyramid for combinatorial polyhedron

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.2
Component: geometry Keywords: pyramid, combinatorial polyhedron
Cc: jipilab, gh-LaisRast, tscrim Merged in:
Authors: Jonathan Kliem Reviewers: Matthias Koeppe, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: e62da00 (Commits, GitHub, GitLab) Commit: e62da007f813ad941357dce138190238ef753821
Dependencies: Stopgaps:

Status badges

Description

We implement a pyramid method for CombinatorialPolyhedron.

Change History (8)

comment:1 Changed 8 months ago by gh-kliem

  • Cc jipilab gh-LaisRast added
  • Status changed from new to needs_review

comment:2 follow-up: Changed 7 months ago by mkoeppe

  • Cc tscrim added

appex -> apex

comment:3 Changed 7 months ago by git

  • Commit changed from b35a670afa3baaf8bb150f3ed1b007192a292988 to e62da007f813ad941357dce138190238ef753821

Branch pushed to git repo; I updated commit sha1. New commits:

e62da00typo

comment:4 in reply to: ↑ 2 Changed 7 months ago by gh-kliem

Replying to mkoeppe:

appex -> apex

Done. At least you see that the constructor really uses the user input.

comment:5 Changed 7 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe, ...

Looks good to me but it would be good if someone more familiar with Cython could take another look.

comment:6 Changed 7 months ago by tscrim

  • Reviewers changed from Matthias Koeppe, ... to Matthias Koeppe, Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 Changed 7 months ago by gh-kliem

Thank you.

comment:8 Changed 7 months ago by vbraun

  • Branch changed from u/gh-kliem/combinatorial_pyramid to e62da007f813ad941357dce138190238ef753821
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.