#30439 closed defect (fixed)

Graphs: fix bug in OrthogonalDualPolarGraph due to pointless conversion to float

Reported by: gh-Ivo-Maffei Owned by:
Priority: major Milestone: sage-9.2
Component: graph theory Keywords:
Cc: dimpase Merged in:
Authors: Ivo Maffei Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 10a1ca1 (Commits, GitHub, GitLab) Commit: 10a1ca1fc537db4e9cfeb79f9afda00000010823
Dependencies: Stopgaps:

Status badges

Description

In graphs.OrthogonalDualPolarGraph if the parameter q is an int, then python converts the intersection size to a float and GAP complains about it:

sage: graphs.OrthogonalDualPolarGraph(1, 3, int(2))
...
AttributeError: 'float' object has no attribute '_libgap_init_'

This is fixed by using integer division //.

Change History (4)

comment:1 Changed 13 months ago by gh-Ivo-Maffei

  • Branch set to public/graphs/30439
  • Commit set to 10a1ca1fc537db4e9cfeb79f9afda00000010823
  • Status changed from new to needs_review

New commits:

10a1ca1integer division in orthogonal dual polar

comment:2 Changed 13 months ago by gh-Ivo-Maffei

  • Cc dimpase added

comment:3 Changed 13 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:4 Changed 13 months ago by vbraun

  • Branch changed from public/graphs/30439 to 10a1ca1fc537db4e9cfeb79f9afda00000010823
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.