#30428 closed enhancement (fixed)

More direct check for simple/simplicial polytopes

Reported by: gh-kliem Owned by:
Priority: minor Milestone: sage-9.2
Component: geometry Keywords: simple, simplicial, combinatorial polyheddron
Cc: jipilab, gh-LaisRast, tscrim Merged in:
Authors: Jonathan Kliem Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 39f3a38 (Commits, GitHub, GitLab) Commit: 39f3a389993dae51d40154a000e4bd79d150910b
Dependencies: Stopgaps:

Status badges

Description

We simplify checking for whether a polyhedron is simple or simplicial by just counting the number of set bits in the vertices/facets.

Change History (7)

comment:1 Changed 11 months ago by gh-kliem

  • Priority changed from major to minor

comment:2 Changed 11 months ago by gh-kliem

  • Branch set to public/30428
  • Commit set to 39f3a389993dae51d40154a000e4bd79d150910b
  • Status changed from new to needs_review

New commits:

39f3a38directly check is_simple/is_simplicial

comment:3 Changed 11 months ago by gh-kliem

  • Cc jipilab gh-LaisRast added

comment:4 Changed 11 months ago by mkoeppe

  • Cc tscrim added

comment:5 Changed 11 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 11 months ago by gh-kliem

Thanks.

comment:7 Changed 11 months ago by vbraun

  • Branch changed from public/30428 to 39f3a389993dae51d40154a000e4bd79d150910b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.