Opened 16 months ago

Last modified 5 months ago

#30415 new task

Remove pyflakes?

Reported by: gh-tobiasdiez Owned by:
Priority: major Milestone: sage-9.5
Component: build Keywords:
Cc: mkoeppe, chapoton, gh-mjungmath, gh-kliem Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

With #30361 and #30404 pyright is added as a static type checker. Besides type checking, it also includes almost all checks that are performed by pyflakes.

As far as I can see, the differences are as follows:

  • Pyright excels at type checking
  • Pyflakes has no support for type checking, and indeed is not even able to handle basic typing syntax (this would need among others https://github.com/PyCQA/pyflakes/pull/530, which seems to be stale)
  • Pyflakes checks for basic validity of the arguments to "format" and "print", this is not supported by pyright

So it depends on how important the print and format validation are. Maybe they are also covered by lgtm?

Resources:

Depending on the outcome, the stub documentation of pyflakes added in #30361 needs be extended or removed.

Change History (3)

comment:2 Changed 10 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:3 Changed 5 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5
Note: See TracTickets for help on using tickets.