Opened 2 years ago
Closed 2 years ago
#30372 closed defect (fixed)
Replace NumberField_generic.__latex_variable_name by ._latex_names
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  number fields  Keywords:  
Cc:  ghkliem, vdelecroix, tscrim  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  da551dc (Commits, GitHub, GitLab)  Commit:  da551dcf21959eb14e768656c7d55a6ad8760f14 
Dependencies:  Stopgaps: 
Description (last modified by )
as observed in #30360,
sage: K3.<a> = NumberField(x^3+x^2+1, latex_name=['alpha']) sage: K3.latex_variable_names() ['a'] sage: K3.latex_variable_name() 'alpha'
We fix this by changing the attribute __latex_variable_name
, only used in NumberField_generic
, to the widely used _latex_names
.
We also deprecate the method latex_variable_name
, which is also only used in sage.rings.number_field
, changing its uses to latex_variable_names
.
Change History (10)
comment:1 Changed 2 years ago by
 Description modified (diff)
comment:2 Changed 2 years ago by
 Description modified (diff)
comment:3 Changed 2 years ago by
 Branch set to u/mkoeppe/replace_numberfield_generic___latex_variable_name_by___latex_name
comment:4 Changed 2 years ago by
 Commit set to 1842e477e5c54140b77dae80ace0554387bf7863
 Status changed from new to needs_review
comment:5 Changed 2 years ago by
 Summary changed from Replace NumberField_generic.__latex_variable_name by ._latex_name to Replace NumberField_generic.__latex_variable_name by ._latex_names
comment:6 Changed 2 years ago by
 Commit changed from 1842e477e5c54140b77dae80ace0554387bf7863 to 6697bca3c89ddae1be7ffcc5e4464832f6475199
Branch pushed to git repo; I updated commit sha1. New commits:
6697bca  Fixup

comment:7 Changed 2 years ago by
 Reviewers set to Travis Scrimshaw
Green patchbot => positive review.
comment:8 Changed 2 years ago by
 Commit changed from 6697bca3c89ddae1be7ffcc5e4464832f6475199 to da551dcf21959eb14e768656c7d55a6ad8760f14
Branch pushed to git repo; I updated commit sha1. New commits:
da551dc  src/sage/rings/number_field/number_field.py: Fix error found by pyflakes

comment:9 Changed 2 years ago by
 Status changed from needs_review to positive_review
Thank you! All green
comment:10 Changed 2 years ago by
 Branch changed from u/mkoeppe/replace_numberfield_generic___latex_variable_name_by___latex_name to da551dcf21959eb14e768656c7d55a6ad8760f14
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
sage.rings.number_field.number_field.NumberField_generic: Use _latex_names instead of __latex_variable_name, deprecate .latex_variable_name()