#30356 closed enhancement (fixed)

Graphs: grouped sporadic distance-regular graphs in a function

Reported by: gh-Ivo-Maffei Owned by:
Priority: major Milestone: sage-9.3
Component: graph theory Keywords:
Cc: dimpase Merged in:
Authors: Ivo Maffei Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 0a9a194 (Commits, GitHub, GitLab) Commit: 0a9a194f473bb7f08bd0721d3d8ab65c410ea86c
Dependencies: #30355, #30343 Stopgaps:

Status badges

Description

Added a function distance_regular_graph with the purpose to build distance-regular graphs given their intersection array. At the moment we grouped only the sporadic constructions and serious existence checks are only done via the external package https://github.com/jaanos/sage-drg.

Change History (23)

comment:1 Changed 16 months ago by gh-Ivo-Maffei

  • Branch set to public/graphs/30356
  • Cc dimpase added
  • Commit set to bd5ef0ab1280d60d0e764c5ed3e4232a621f0775
  • Dependencies changed from #300355 to #30355
  • Status changed from new to needs_review

I will add more constructions to this function later on. Now I'm mainly concerned with how to handle the drg package.


Last 10 new commits:

35a457eMerge branch 30337 into 30343
d0ca365Merge branch 'drg_gen_pol' into drg_general_func
0268857fixed most sporadic graphs; added some docstring; added method to graphs
51dda87added (extended) bipartite double method to undirected graphs
eed2fe3fix bug with extended bipartite
0f2dcceadded more doctests
13dc48aMerge branch 30240 into bipartite_double
864cd35Merge branch 'bipartite_double' into drg_general_func
17a0b90completed sporadic database; added more docstrings; added basic checks
bd5ef0afixed docstring and doctests

comment:2 Changed 16 months ago by git

  • Commit changed from bd5ef0ab1280d60d0e764c5ed3e4232a621f0775 to 1a143bc06e557416a3fcfaa4dbc9611e344ec357

Branch pushed to git repo; I updated commit sha1. New commits:

2d6c8bafix docstring; added doctests; simplier code
1a143bcMerge branch #30355 into #30356

comment:3 Changed 16 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to needs_work

after merging beta9 in, doctests fail, e.g.

File "src/sage/graphs/generators/distance_regular.pyx", line 15, in sage.graphs.generators.distance_regular
Failed example:
    H = graphs.distance_regular_graph([15, 14, 10, 3, 1, 5, 12, 15])
Exception raised:
    Traceback (most recent call last):
      File "/mnt/opt/Sage/sage-dev/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 715, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/mnt/opt/Sage/sage-dev/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 1139, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.graphs.generators.distance_regular[2]>", line 1, in <module>
        H = graphs.distance_regular_graph([Integer(15), Integer(14), Integer(10), Integer(3), Integer(1), Integer(5), Integer(12), Integer(15)])
      File "sage/graphs/generators/distance_regular.pyx", line 1902, in sage.graphs.generators.distance_regular.distance_regular_graph (build/cythonized/sage/graphs/generators/distance_regular.c:25204)
        any([(arr[d+i+1] - arr[d+i]) < 0 for i in range(d)]):
    IndexError: list index out of range

comment:4 Changed 16 months ago by git

  • Commit changed from 1a143bc06e557416a3fcfaa4dbc9611e344ec357 to 085d36e9b07549eae631804285256bcbc4b04222

Branch pushed to git repo; I updated commit sha1. New commits:

4d91c20Merge branch 9.2.beta9 into 30356
085d36efixed existence checks without drg module

comment:5 Changed 16 months ago by gh-Ivo-Maffei

  • Status changed from needs_work to needs_review

I forgot to test the code without the drg module. Now it should be fixed.

comment:6 Changed 16 months ago by dimpase

  • Status changed from needs_review to needs_work

this ticket also gets shot down by dog-slow and memory-hungry sage.graphs.generators.distance_regular.HermitianFormsGraph

comment:7 Changed 16 months ago by gh-Ivo-Maffei

  • Dependencies changed from #30355 to #30355, #30343

comment:8 Changed 16 months ago by git

  • Commit changed from 085d36e9b07549eae631804285256bcbc4b04222 to fd258e823af4155d45650e56de868478b8fd4d83

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

a0463d5fix docsrtings; renamed module
5d16394renamed in design_catalog
e6ff3faMerge branch 't/30223' into t/30337
3e1df8cadded const to half cube
0d92ec4Merge branch 't/30329' into t/30337
ac3ed1aMerge branch 't/30337' into t/30343
376d459convert matrices in bilinearFormsGraph to integers to lower memory requirements
11d9953Merge branch 't/30337' into t/30343
5367858some code formatting
fd258e8Merge branch 't/30343' into t/30356

comment:9 Changed 16 months ago by git

  • Commit changed from fd258e823af4155d45650e56de868478b8fd4d83 to 625b266bb08bfdccacd4fd2d4cc8bb6bf232385d

Branch pushed to git repo; I updated commit sha1. New commits:

625b266added doctests to _integersection_array_from_graph

comment:10 follow-up: Changed 15 months ago by dimpase

should this be rebased over the latests positively reviewed tickets by you?

comment:11 in reply to: ↑ 10 Changed 15 months ago by gh-Ivo-Maffei

Replying to dimpase:

should this be rebased over the latests positively reviewed tickets by you?

Yes. The dependency chain is #30312 -> #30329 -> #30337 -> #30343 -> #30356 At the moment #30312 and #30329 are done. When #30343 will be sorted (rebased on updated #30337), I'll fix this ticket as well

comment:12 Changed 15 months ago by chapoton

It seems to be a not-so-good idea to have such long chains of dependencies, if not really required. This can be blocked at any step. Think parallel instead of series.

comment:13 Changed 15 months ago by dimpase

without refactoring into smaller modules, this looks hard to avoid.

comment:14 Changed 15 months ago by chapoton

Indeed. This was just a non-specific comment.

Note that one of the patchbot plugins is not green.

comment:15 Changed 15 months ago by git

  • Commit changed from 625b266bb08bfdccacd4fd2d4cc8bb6bf232385d to 63c88c0285c1118fcfc7225e702c0c33a8b27bc4

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1fdcad9fixed typo
c97bda5Merge branch 't/30329' into t/30337
3024980faster implementation of HalfCube
898fbeeadded positions to HalfCube
d9c9149Merge branch 't/30509' into t/30337
3449361Merge branch 9.2.beta12 into t/30337
b99474bMerge branch 't/30337' into t/30343
7d17b7dremoved blank lines
717cf19Merge branch 't/30343' into t/30356
63c88c0fix bug; avoid long computations on import

comment:16 Changed 15 months ago by gh-Ivo-Maffei

  • Status changed from needs_work to needs_review

Merged all dependencies and fixed a bug

comment:17 Changed 15 months ago by dimpase

  • Status changed from needs_review to positive_review

OK

comment:18 Changed 14 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:19 Changed 12 months ago by git

  • Commit changed from 63c88c0285c1118fcfc7225e702c0c33a8b27bc4 to 3b617369405253baeb561aa42ed415f512c40ae9
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. Last 10 new commits:

47b0abaremote extra spaces
ad0c3bbtypo in the graph name string
a176e0bmissing #optional tag added
54499c7sketch general function with conditionals for drg module
c5f0f3dfixed most sporadic graphs; added some docstring; added method to graphs
f675f2ccompleted sporadic database; added more docstrings; added basic checks
e4b1d59fixed docstring and doctests
9aa7d07fixed existence checks without drg module
4bba926added doctests to _integersection_array_from_graph
3b61736fix bug; avoid long computations on import

comment:20 Changed 12 months ago by dimpase

rebased over #30343

comment:21 Changed 12 months ago by git

  • Commit changed from 3b617369405253baeb561aa42ed415f512c40ae9 to 0a9a194f473bb7f08bd0721d3d8ab65c410ea86c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0a9a194fix bug; avoid long computations on import - typo fixed

comment:22 Changed 12 months ago by dimpase

  • Status changed from needs_review to positive_review

comment:23 Changed 12 months ago by vbraun

  • Branch changed from public/graphs/30356 to 0a9a194f473bb7f08bd0721d3d8ab65c410ea86c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.